diff mbox

[6/8] ncurses: speed up host build by disabling static library building

Message ID 1417642895-29606-7-git-send-email-thomas.petazzoni@free-electrons.com
State Accepted
Headers show

Commit Message

Thomas Petazzoni Dec. 3, 2014, 9:41 p.m. UTC
For the host variant of packages, we normally only build the shared
libraries. However, ncurses uses non-standard options to select
between shared/static and therefore the host variant was building both
of them, even though the static libraries were unused.

By passing --without-normal, we disable the build of static
libraries. It saves a bit of disk space, and on my laptop,
host-ncurses takes 26 seconds to build instead of 40 seconds.

Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
---
 package/ncurses/ncurses.mk | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Yann E. MORIN Dec. 11, 2014, 8:24 p.m. UTC | #1
Thomas, All,

On 2014-12-03 22:41 +0100, Thomas Petazzoni spake thusly:
> For the host variant of packages, we normally only build the shared
> libraries. However, ncurses uses non-standard options to select
> between shared/static and therefore the host variant was building both
> of them, even though the static libraries were unused.
> 
> By passing --without-normal, we disable the build of static
> libraries. It saves a bit of disk space, and on my laptop,
> host-ncurses takes 26 seconds to build instead of 40 seconds.
> 
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>

There is also --with-libtool, but I guess that would mean to build both
shared and static. Anyway, --without-normal does the trick, so:

Acked-by: "Yann E. MORIN" <yann.morin.1998@free.fr>

Regards,
Yann E. MORIN.

> ---
>  package/ncurses/ncurses.mk | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/package/ncurses/ncurses.mk b/package/ncurses/ncurses.mk
> index 1ce3818..645c25c 100644
> --- a/package/ncurses/ncurses.mk
> +++ b/package/ncurses/ncurses.mk
> @@ -145,7 +145,8 @@ HOST_NCURSES_CONF_OPTS = \
>  	--without-manpages \
>  	--without-cxx \
>  	--without-cxx-binding \
> -	--without-ada
> +	--without-ada \
> +	--without-normal
>  
>  $(eval $(autotools-package))
>  $(eval $(host-autotools-package))
> -- 
> 2.1.0
> 
> _______________________________________________
> buildroot mailing list
> buildroot@busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
diff mbox

Patch

diff --git a/package/ncurses/ncurses.mk b/package/ncurses/ncurses.mk
index 1ce3818..645c25c 100644
--- a/package/ncurses/ncurses.mk
+++ b/package/ncurses/ncurses.mk
@@ -145,7 +145,8 @@  HOST_NCURSES_CONF_OPTS = \
 	--without-manpages \
 	--without-cxx \
 	--without-cxx-binding \
-	--without-ada
+	--without-ada \
+	--without-normal
 
 $(eval $(autotools-package))
 $(eval $(host-autotools-package))