diff mbox

[i386] : Use -mtune=generic for -m32 libitm/libgomp multilibs

Message ID CAFULd4amUejcT2qhXXoaq4xSkZkG7hueaaY1xrMfweiK4e3DiQ@mail.gmail.com
State New
Headers show

Commit Message

Uros Bizjak Dec. 3, 2014, 1:49 p.m. UTC
Hello!

As seen in Fedora gcc patch in pkgs.fedoraproject.org/cgit/gcc.git/ .

libitm/ChangeLog:

2014-12-03  Uros Bizjak  <ubizjak@gmail.com>

    * configure.tgt (x86_64): Tune -m32 multilib to generic.

libgomp/ChangeLog:

2014-12-03  Uros Bizjak  <ubizjak@gmail.com>

    * configure.tgt (x86_64-*-linux*): Tune -m32 multilib to generic.

Any objection for mainline/4.9 branch?

Uros.

Comments

Jakub Jelinek Dec. 3, 2014, 1:52 p.m. UTC | #1
On Wed, Dec 03, 2014 at 02:49:18PM +0100, Uros Bizjak wrote:
> Hello!
> 
> As seen in Fedora gcc patch in pkgs.fedoraproject.org/cgit/gcc.git/ .
> 
> libitm/ChangeLog:
> 
> 2014-12-03  Uros Bizjak  <ubizjak@gmail.com>
> 
>     * configure.tgt (x86_64): Tune -m32 multilib to generic.
> 
> libgomp/ChangeLog:
> 
> 2014-12-03  Uros Bizjak  <ubizjak@gmail.com>
> 
>     * configure.tgt (x86_64-*-linux*): Tune -m32 multilib to generic.
> 
> Any objection for mainline/4.9 branch?

LGTM.

	Jakub
H.J. Lu Dec. 3, 2014, 1:52 p.m. UTC | #2
On Wed, Dec 3, 2014 at 5:49 AM, Uros Bizjak <ubizjak@gmail.com> wrote:
> Hello!
>
> As seen in Fedora gcc patch in pkgs.fedoraproject.org/cgit/gcc.git/ .
>
> libitm/ChangeLog:
>
> 2014-12-03  Uros Bizjak  <ubizjak@gmail.com>
>
>     * configure.tgt (x86_64): Tune -m32 multilib to generic.
>
> libgomp/ChangeLog:
>
> 2014-12-03  Uros Bizjak  <ubizjak@gmail.com>
>
>     * configure.tgt (x86_64-*-linux*): Tune -m32 multilib to generic.
>
> Any objection for mainline/4.9 branch?
>

I like it.

Thanks.
Uros Bizjak Dec. 3, 2014, 2:11 p.m. UTC | #3
On Wed, Dec 3, 2014 at 2:52 PM, H.J. Lu <hjl.tools@gmail.com> wrote:

>> As seen in Fedora gcc patch in pkgs.fedoraproject.org/cgit/gcc.git/ .
>>
>> libitm/ChangeLog:
>>
>> 2014-12-03  Uros Bizjak  <ubizjak@gmail.com>
>>
>>     * configure.tgt (x86_64): Tune -m32 multilib to generic.
>>
>> libgomp/ChangeLog:
>>
>> 2014-12-03  Uros Bizjak  <ubizjak@gmail.com>
>>
>>     * configure.tgt (x86_64-*-linux*): Tune -m32 multilib to generic.
>>
>> Any objection for mainline/4.9 branch?
>>
>
> I like it.

Committed to mainline and 4.9 branch.

Uros.
diff mbox

Patch

Index: libitm/configure.tgt
===================================================================
--- libitm/configure.tgt	(revision 218302)
+++ libitm/configure.tgt	(working copy)
@@ -102,7 +102,7 @@ 
   x86_64)
 	case " ${CC} ${CFLAGS} " in
 	  *" -m32 "*)
-	    XCFLAGS="${XCFLAGS} -march=i486 -mtune=i686"
+	    XCFLAGS="${XCFLAGS} -march=i486 -mtune=generic"
 	    XCFLAGS="${XCFLAGS} -fomit-frame-pointer"
 	    ;;
 	esac
Index: libgomp/configure.tgt
===================================================================
--- libgomp/configure.tgt	(revision 218302)
+++ libgomp/configure.tgt	(working copy)
@@ -82,7 +82,7 @@ 
 	config_path="linux/x86 linux posix"
 	case " ${CC} ${CFLAGS} " in
 	  *" -m32 "*)
-	    XCFLAGS="${XCFLAGS} -march=i486 -mtune=i686"
+	    XCFLAGS="${XCFLAGS} -march=i486 -mtune=generic"
 	    ;;
 	esac
 	;;