Patchwork [net-next,v2,9/9] llc: remove unused APIs (which should be private anyway)

login
register
mail settings
Submitter Octavian Purdila
Date Dec. 23, 2009, 11:45 p.m.
Message ID <1261611934-24348-10-git-send-email-opurdila@ixiacom.com>
Download mbox | patch
Permalink /patch/41727/
State Changes Requested
Delegated to: David Miller
Headers show

Comments

Octavian Purdila - Dec. 23, 2009, 11:45 p.m.
Remove the list & lock from the exported API - it is not used anywhere
in the tree and most operations should be covered by llc_sap_open(),
llc_sap_close() and llc_sap_find().

Signed-off-by: Octavian Purdila <opurdila@ixiacom.com>
---
 include/net/llc.h  |    1 -
 net/llc/llc_core.c |    4 +---
 2 files changed, 1 insertions(+), 4 deletions(-)

Patch

diff --git a/include/net/llc.h b/include/net/llc.h
index aee826d..7b9528b 100644
--- a/include/net/llc.h
+++ b/include/net/llc.h
@@ -92,7 +92,6 @@  struct hlist_nulls_head *llc_sk_laddr_hash(struct llc_sap *sap,
 #define LLC_DEST_CONN            2      /* Type 2 goes here */
 
 extern struct list_head llc_sap_list;
-extern spinlock_t llc_sap_list_lock;
 
 extern int llc_rcv(struct sk_buff *skb, struct net_device *dev,
 		   struct packet_type *pt, struct net_device *orig_dev);
diff --git a/net/llc/llc_core.c b/net/llc/llc_core.c
index 21fe87e..3f4e85b 100644
--- a/net/llc/llc_core.c
+++ b/net/llc/llc_core.c
@@ -23,7 +23,7 @@ 
 #include <net/llc.h>
 
 LIST_HEAD(llc_sap_list);
-DEFINE_SPINLOCK(llc_sap_list_lock);
+static DEFINE_SPINLOCK(llc_sap_list_lock);
 
 /**
  *	llc_sap_alloc - allocates and initializes sap.
@@ -160,8 +160,6 @@  static void __exit llc_exit(void)
 module_init(llc_init);
 module_exit(llc_exit);
 
-EXPORT_SYMBOL(llc_sap_list);
-EXPORT_SYMBOL(llc_sap_list_lock);
 EXPORT_SYMBOL(llc_sap_find);
 EXPORT_SYMBOL(llc_sap_open);
 EXPORT_SYMBOL(llc_sap_close);