| Message ID | 1417552078-9269-9-git-send-email-christophe-h.ricard@st.com |
|---|---|
| State | Superseded, archived |
| Headers | show |
Hi Christophe, On Tue, Dec 02, 2014 at 09:27:53PM +0100, Christophe Ricard wrote: > Other drivers are following the following compatible string format for dts: > s/_/-/ You're basically breaking an ABI here. If anyone has built and shipped a DT binding firmware with the current compatible string, you're making sure 3.19 won't work with their firmware. I know it's very unlikely, but for the sake of it I prefer not taking that patch and the following one. Cheers, Samuel. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/Documentation/devicetree/bindings/net/nfc/st21nfca.txt b/Documentation/devicetree/bindings/net/nfc/st21nfca.txt index e4faa2e..db677fe 100644 --- a/Documentation/devicetree/bindings/net/nfc/st21nfca.txt +++ b/Documentation/devicetree/bindings/net/nfc/st21nfca.txt @@ -1,7 +1,7 @@ * STMicroelectronics SAS. ST21NFCA NFC Controller Required properties: -- compatible: Should be "st,st21nfca_i2c". +- compatible: Should be "st,st21nfca-i2c". - clock-frequency: I²C work frequency. - reg: address on the bus - interrupt-parent: phandle for the interrupt gpio controller @@ -20,7 +20,7 @@ Example (for ARM-based BeagleBoard xM with ST21NFCA on I2C2): st21nfca: st21nfca@1 { - compatible = "st,st21nfca_i2c"; + compatible = "st,st21nfca-i2c"; reg = <0x01>; clock-frequency = <400000>; diff --git a/drivers/nfc/st21nfca/i2c.c b/drivers/nfc/st21nfca/i2c.c index 44e1c76..a9188c2 100644 --- a/drivers/nfc/st21nfca/i2c.c +++ b/drivers/nfc/st21nfca/i2c.c @@ -661,7 +661,7 @@ static int st21nfca_hci_i2c_remove(struct i2c_client *client) #ifdef CONFIG_OF static const struct of_device_id of_st21nfca_i2c_match[] = { - { .compatible = "st,st21nfca_i2c", }, + { .compatible = "st,st21nfca-i2c", }, {} }; MODULE_DEVICE_TABLE(of, of_st21nfca_i2c_match);
Other drivers are following the following compatible string format for dts: s/_/-/ Signed-off-by: Christophe Ricard <christophe-h.ricard@st.com> --- Documentation/devicetree/bindings/net/nfc/st21nfca.txt | 4 ++-- drivers/nfc/st21nfca/i2c.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-)