| Message ID | 1417545429-11283-1-git-send-email-boris.brezillon@free-electrons.com |
|---|---|
| State | Accepted |
| Commit | c96736092464cd653a7cada7f4e3ca1df656a760 |
| Headers | show |
On Tue, Dec 02, 2014 at 07:37:09PM +0100, Boris Brezillon wrote: > Now that we have raw functions properly implemented we can remove this > FIXME. > > Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com> > --- > drivers/mtd/nand/gpmi-nand/gpmi-nand.c | 8 -------- > 1 file changed, 8 deletions(-) > > diff --git a/drivers/mtd/nand/gpmi-nand/gpmi-nand.c b/drivers/mtd/nand/gpmi-nand/gpmi-nand.c > index 4f3851a..5d2cc9e 100644 > --- a/drivers/mtd/nand/gpmi-nand/gpmi-nand.c > +++ b/drivers/mtd/nand/gpmi-nand/gpmi-nand.c > @@ -1294,14 +1294,6 @@ exit_auxiliary: > * ecc.read_page or ecc.read_page_raw function. Thus, the fact that MTD wants an > * ECC-based or raw view of the page is implicit in which function it calls > * (there is a similar pair of ECC-based/raw functions for writing). > - * > - * FIXME: The following paragraph is incorrect, now that there exist > - * ecc.read_oob_raw and ecc.write_oob_raw functions. > - * > - * Since MTD assumes the OOB is not covered by ECC, there is no pair of > - * ECC-based/raw functions for reading or or writing the OOB. The fact that the > - * caller wants an ECC-based or raw view of the page is not propagated down to > - * this driver. > */ > static int gpmi_ecc_read_oob(struct mtd_info *mtd, struct nand_chip *chip, > int page) Acked-by: Huang Shijie <shijie.huang@intel.com>
On Tue, Dec 02, 2014 at 07:37:09PM +0100, Boris Brezillon wrote: > Now that we have raw functions properly implemented we can remove this > FIXME. > > Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com> Pushed to l2-mtd.git/next. Thanks! Brian
diff --git a/drivers/mtd/nand/gpmi-nand/gpmi-nand.c b/drivers/mtd/nand/gpmi-nand/gpmi-nand.c index 4f3851a..5d2cc9e 100644 --- a/drivers/mtd/nand/gpmi-nand/gpmi-nand.c +++ b/drivers/mtd/nand/gpmi-nand/gpmi-nand.c @@ -1294,14 +1294,6 @@ exit_auxiliary: * ecc.read_page or ecc.read_page_raw function. Thus, the fact that MTD wants an * ECC-based or raw view of the page is implicit in which function it calls * (there is a similar pair of ECC-based/raw functions for writing). - * - * FIXME: The following paragraph is incorrect, now that there exist - * ecc.read_oob_raw and ecc.write_oob_raw functions. - * - * Since MTD assumes the OOB is not covered by ECC, there is no pair of - * ECC-based/raw functions for reading or or writing the OOB. The fact that the - * caller wants an ECC-based or raw view of the page is not propagated down to - * this driver. */ static int gpmi_ecc_read_oob(struct mtd_info *mtd, struct nand_chip *chip, int page)
Now that we have raw functions properly implemented we can remove this FIXME. Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com> --- drivers/mtd/nand/gpmi-nand/gpmi-nand.c | 8 -------- 1 file changed, 8 deletions(-)