[4/N,v2,x86_64] Vectorized math functions
diff mbox

Message ID CAMXFM3tnPWA=f_z5wQYroEFHqUrKiy2C6ytY=s_7BTzONPL4Zg@mail.gmail.com
State New
Headers show

Commit Message

Andrew Senkevich Dec. 2, 2014, 4:45 p.m. UTC
This patch adds infrastructure for addition of SIMD declarations for
math functions in math.h.
Added new headers math-vector.h and libm-simd-decl-stubs.h with empty
definitions required for proper unfolding of new macros __MATHCALL_VEC
which will be used for declaration of vector math functions.

2014-12-02  Andrew Senkevich  <andrew.n.senkevich@gmail.com>

        * bits/math-vector.h: New file.
        * bits/libm-simd-decl-stubs.h: Likewise.
        * math/Makefile (headers): Added new header libm-simd-decl-stubs.h.
        * math/math.h (__MATHCALL_VEC): New macro.


Is it Ok?


--
WBR,
Andrew

Comments

Joseph Myers Dec. 3, 2014, 5:56 p.m. UTC | #1
On Tue, 2 Dec 2014, Andrew Senkevich wrote:

> +#ifndef _MATH_H
> +# error "Never include <bits/libm-simd-decl-stubs.h> directly; \
> +        include <math.h> instead."
> +#endif

If you continue a #error line like that, I think you should still ensure 
there aren't excess spaces in the string (so either put the backslash 
immediately after ';', with a single space's indentation on the next line, 
or have no indentation on the next line at all).

> +#ifndef _LIBM_SIMD_DECL_STUBS_H
> +#define _LIBM_SIMD_DECL_STUBS_H 1

I think the header guard name should start with _BITS_ now it's a bits/ 
header.

> +#ifndef _MATH_H
> +# error "Never include <bits/math-vector.h> directly; \
> + include <math.h> instead."

Same point about avoiding multiple consecutive spaces in mid-sentence.

> +/* Get machine-dependent vector math functions declarations */

Comments should end ".  */" (".", two spaces, end of comment).

Patch
diff mbox

diff --git a/bits/libm-simd-decl-stubs.h b/bits/libm-simd-decl-stubs.h
new file mode 100644
index 0000000..e8ca1ee
--- /dev/null
+++ b/bits/libm-simd-decl-stubs.h
@@ -0,0 +1,40 @@ 
+/* Empty definitions required for __MATHCALL_VEC unfolding in mathcalls.h.
+   Copyright (C) 2014 Free Software Foundation, Inc.
+   This file is part of the GNU C Library.
+
+   The GNU C Library is free software; you can redistribute it and/or
+   modify it under the terms of the GNU Lesser General Public
+   License as published by the Free Software Foundation; either
+   version 2.1 of the License, or (at your option) any later version.
+
+   The GNU C Library is distributed in the hope that it will be useful,
+   but WITHOUT ANY WARRANTY; without even the implied warranty of
+   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+   Lesser General Public License for more details.
+
+   You should have received a copy of the GNU Lesser General Public
+   License along with the GNU C Library; if not, see
+   <http://www.gnu.org/licenses/>.  */
+
+#ifndef _MATH_H
+# error "Never include <bits/libm-simd-decl-stubs.h> directly; \
+        include <math.h> instead."
+#endif
+
+/* Needed definitions could be generated with:
+   for func in $(grep __MATHCALL_VEC math/bits/mathcalls.h |\
+ sed -r "s|__MATHCALL_VEC.?\(||; s|,.*||"); do
+     echo "#define __DECL_SIMD_${func}";
+     echo "#define __DECL_SIMD_${func}f";
+     echo "#define __DECL_SIMD_${func}l";
+   done
+ */
+
+#ifndef _LIBM_SIMD_DECL_STUBS_H
+#define _LIBM_SIMD_DECL_STUBS_H 1
+
+#define __DECL_SIMD_cos
+#define __DECL_SIMD_cosf
+#define __DECL_SIMD_cosl
+
+#endif
diff --git a/bits/math-vector.h b/bits/math-vector.h
new file mode 100644
index 0000000..84f67fa
--- /dev/null
+++ b/bits/math-vector.h
@@ -0,0 +1,27 @@ 
+/* Platform-specific SIMD declarations of math functions.
+   Copyright (C) 2014 Free Software Foundation, Inc.
+   This file is part of the GNU C Library.
+
+   The GNU C Library is free software; you can redistribute it and/or
+   modify it under the terms of the GNU Lesser General Public
+   License  published by the Free Software Foundation; either
+   version 2.1 of the License, or (at your option) any later version.
+
+   The GNU C Library is distributed in the hope that it will be useful,
+   but WITHOUT ANY WARRANTY; without even the implied warranty of
+   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+   Lesser General Public License for more details.
+
+   You should have received a copy of the GNU Lesser General Public
+   License along with the GNU C Library; if not, see
+   <http://www.gnu.org/licenses/>.  */
+
+#ifndef _MATH_H
+# error "Never include <bits/math-vector.h> directly; \
+ include <math.h> instead."
+#endif
+
+/* Get default empty definitions required for __MATHCALL_VEC unfolding.
+   Plaform-specific analogue of this header should redefine them with specific
+   SIMD declarations. */
+#include <bits/libm-simd-decl-stubs.h>
diff --git a/math/Makefile b/math/Makefile
index 73d299d..fbd2ded 100644
--- a/math/Makefile
+++ b/math/Makefile
@@ -26,7 +26,8 @@  headers := math.h bits/mathcalls.h bits/mathinline.h
bits/huge_val.h \
    bits/huge_valf.h bits/huge_vall.h bits/inf.h bits/nan.h \
    fpu_control.h complex.h bits/cmathcalls.h fenv.h \
    bits/fenv.h bits/fenvinline.h bits/mathdef.h tgmath.h \
-   bits/math-finite.h
+   bits/math-finite.h bits/math-vector.h \
+   bits/libm-simd-decl-stubs.h

 # FPU support code.
 aux := setfpucw fpu_control
diff --git a/math/math.h b/math/math.h
index dc532b7..0f3e36b 100644
--- a/math/math.h
+++ b/math/math.h
@@ -27,6 +27,9 @@ 

 __BEGIN_DECLS

+/* Get machine-dependent vector math functions declarations */
+#include <bits/math-vector.h>
+
 /* Get machine-dependent HUGE_VAL value (returned on overflow).
    On all IEEE754 machines, this is +Infinity.  */
 #include <bits/huge_val.h>
@@ -49,6 +52,12 @@  __BEGIN_DECLS
    so we can easily declare each function as both `name' and `__name',
    and can declare the float versions `namef' and `__namef'.  */

+#define __SIMD_DECL(function) __CONCAT (__DECL_SIMD_, function)
+
+#define __MATHCALL_VEC(function, suffix, args) \
+  __SIMD_DECL (__MATH_PRECNAME (function, suffix)) \
+  __MATHCALL (function, suffix, args)
+
 #define __MATHCALL(function,suffix, args) \
   __MATHDECL (_Mdouble_,function,suffix, args)
 #define __MATHDECL(type, function,suffix, args) \