From patchwork Wed Dec 23 14:40:36 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sarveshwar Bandi X-Patchwork-Id: 41670 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id D8907B7BE5 for ; Thu, 24 Dec 2009 01:40:36 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755896AbZLWOkc (ORCPT ); Wed, 23 Dec 2009 09:40:32 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755186AbZLWOkb (ORCPT ); Wed, 23 Dec 2009 09:40:31 -0500 Received: from segment-124-30.sify.net ([124.30.166.146]:11196 "EHLO akhaparde.serverengines.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1750986AbZLWOkb (ORCPT ); Wed, 23 Dec 2009 09:40:31 -0500 Received: by akhaparde.serverengines.com (Postfix, from userid 1002) id 9F015324E3; Wed, 23 Dec 2009 20:10:36 +0530 (IST) Date: Wed, 23 Dec 2009 20:10:36 +0530 From: Sarveshwar Bandi To: netdev@vger.kernel.org Cc: davem@davemloft.net Subject: [net-2.6 PATCH 1/3] be2net: Bug fix to avoid soft lockup in loopback test. Message-ID: <20091223144026.GA23383@serverengines.com> Reply-To: Sarveshwar Bandi MIME-Version: 1.0 Content-Disposition: inline X-URL: http://www.serverengines.com Organization: Server Engines User-Agent: "Mutt" X-OS: Linux x86_64 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org This change ensures that loopback test command gives up after 4 seconds when the hardware is not responsive. This could happen if the ports are connected properly in loopback mode. Signed-off-by: Sarveshwar Bandi --- drivers/net/benet/be_cmds.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/net/benet/be_cmds.c b/drivers/net/benet/be_cmds.c index 1b68bd9..a27fdb3 100644 --- a/drivers/net/benet/be_cmds.c +++ b/drivers/net/benet/be_cmds.c @@ -1501,6 +1501,7 @@ int be_cmd_loopback_test(struct be_adapt be_cmd_hdr_prepare(&req->hdr, CMD_SUBSYSTEM_LOWLEVEL, OPCODE_LOWLEVEL_LOOPBACK_TEST, sizeof(*req)); + req->hdr.timeout = 4; req->pattern = cpu_to_le64(pattern); req->src_port = cpu_to_le32(port_num);