[x86] Update options for avx512 testsuite.

Message ID	20141201163503.GA128172@msticlxl7.ims.intel.com
State	New
Headers	show Return-Path: <gcc-patches-return-386226-incoming=patchwork.ozlabs.org@gcc.gnu.org> DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:date :from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; q=dns; s=default; b=lO9Oe5f6m5MhImLwW t2jHoRErUIBANFun/m3LYEVjRZpVCNE+1ou50Z0fMWsFZX84vxertuRJZt6S/Glg WziQ6tCzNHxoMlbefxWdhMuPpc90lUSWBWog39y4vVDKu6IfZEaoRJfpgQ0BWVWs kXE1UkK59txLIFpku+Wgt4PG/0= Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk Sender: gcc-patches-owner@gcc.gnu.org Date: Mon, 1 Dec 2014 19:35:03 +0300 From: Ilya Tocar <tocarip.intel@gmail.com> To: "H.J. Lu" <hjl.tools@gmail.com> Cc: Uros Bizjak <ubizjak@gmail.com>, GCC Patches <gcc-patches@gcc.gnu.org> Subject: Re: [PATCH x86] Update options for avx512 testsuite. Message-ID: <20141201163503.GA128172@msticlxl7.ims.intel.com> References: <20141128150848.GA74953@msticlxl7.ims.intel.com> <CAFULd4aC-tdygk1Nuh=DyKjbV6kkA8_LreUwubJoWf+89uNF2g@mail.gmail.com> <CAMe9rOrCpw3pE0WHyjD33OM2TQ6BOQXqOhhtHwhJJteF1p2BJg@mail.gmail.com> <CAMe9rOrAtKfdDsWUL=QeX=H=cs5hw20AmNfSu7uNtmwz7yTopw@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <CAMe9rOrAtKfdDsWUL=QeX=H=cs5hw20AmNfSu7uNtmwz7yTopw@mail.gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12)

Message ID

20141201163503.GA128172@msticlxl7.ims.intel.com

State

New

Headers

DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id
	:list-unsubscribe:list-archive:list-post:list-help:sender:date
	:from:to:cc:subject:message-id:references:mime-version
	:content-type:in-reply-to; q=dns; s=default; b=lO9Oe5f6m5MhImLwW
	t2jHoRErUIBANFun/m3LYEVjRZpVCNE+1ou50Z0fMWsFZX84vxertuRJZt6S/Glg
	WziQ6tCzNHxoMlbefxWdhMuPpc90lUSWBWog39y4vVDKu6IfZEaoRJfpgQ0BWVWs
	kXE1UkK59txLIFpku+Wgt4PG/0=
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
Sender: gcc-patches-owner@gcc.gnu.org
Date: Mon, 1 Dec 2014 19:35:03 +0300
From: Ilya Tocar <tocarip.intel@gmail.com>
To: "H.J. Lu" <hjl.tools@gmail.com>
Cc: Uros Bizjak <ubizjak@gmail.com>, GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH x86] Update options for avx512 testsuite.
Message-ID: <20141201163503.GA128172@msticlxl7.ims.intel.com>
References: <20141128150848.GA74953@msticlxl7.ims.intel.com>
	<CAFULd4aC-tdygk1Nuh=DyKjbV6kkA8_LreUwubJoWf+89uNF2g@mail.gmail.com>
	<CAMe9rOrCpw3pE0WHyjD33OM2TQ6BOQXqOhhtHwhJJteF1p2BJg@mail.gmail.com>
	<CAMe9rOrAtKfdDsWUL=QeX=H=cs5hw20AmNfSu7uNtmwz7yTopw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAMe9rOrAtKfdDsWUL=QeX=H=cs5hw20AmNfSu7uNtmwz7yTopw@mail.gmail.com>
User-Agent: Mutt/1.5.23 (2014-03-12)

Commit Message

Ilya Tocar Dec. 1, 2014, 4:35 p.m. UTC

> > I saw
> >
> > FAIL: gcc.dg/vect/costmodel/i386/costmodel-fast-math-vect-pr29925.c
> > scan-tree-dump-times vect "vectorized 1 loops" 1
> > FAIL: gcc.dg/vect/costmodel/x86_64/costmodel-fast-math-vect-pr29925.c
> > scan-tree-dump-times vect "vectorized 1 loops" 1
> > FAIL: gcc.target/i386/avx256-unaligned-store-2.c scan-assembler
> > vmovups.*\\\\*movv16qi_internal/3
> > FAIL: gcc.target/i386/avx512ifma-vpmaddhuq-2.c (test for excess errors)
> > UNRESOLVED: gcc.target/i386/avx512ifma-vpmaddhuq-2.c compilation
> > failed to produce executable
> > FAIL: gcc.target/i386/avx512ifma-vpmaddluq-2.c (test for excess errors)
> > UNRESOLVED: gcc.target/i386/avx512ifma-vpmaddluq-2.c compilation
> > failed to produce executable
> > FAIL: gcc.target/i386/avx512vbmi-vpermb-2.c (test for excess errors)
> > UNRESOLVED: gcc.target/i386/avx512vbmi-vpermb-2.c compilation failed
> > to produce executable
> > FAIL: gcc.target/i386/avx512vbmi-vpermi2b-2.c (test for excess errors)
> > UNRESOLVED: gcc.target/i386/avx512vbmi-vpermi2b-2.c compilation failed
> > to produce executable
> > FAIL: gcc.target/i386/avx512vbmi-vpermt2b-2.c (test for excess errors)
> > UNRESOLVED: gcc.target/i386/avx512vbmi-vpermt2b-2.c compilation failed
> > to produce executable
> > FAIL: gcc.target/i386/avx512vbmi-vpmultishiftqb-2.c (test for excess errors)
> > UNRESOLVED: gcc.target/i386/avx512vbmi-vpmultishiftqb-2.c compilation
> > failed to produce executable
> >
> > on x86:
> >
> > https://gcc.gnu.org/ml/gcc-testresults/2014-12/msg00030.html
> >
> >
> 
> I took a look at one of them:
> 
> diff --git a/gcc/testsuite/gcc.target/i386/avx512vbmi-vpmultishiftqb-2.c
> b/gcc/testsuite/gcc.target/i386/avx512vbmi-vpmultishiftqb-2.c
> index 936d938..861dce2 100644
> --- a/gcc/testsuite/gcc.target/i386/avx512vbmi-vpmultishiftqb-2.c
> +++ b/gcc/testsuite/gcc.target/i386/avx512vbmi-vpmultishiftqb-2.c
> @@ -1,5 +1,5 @@
>  /* { dg-do run } */
> -/* { dg-options "-O2 -mavx512vbmi -DAVX512VBMI" } */
> +/* { dg-options "-O2 -mavx512vbmi" } */
>  /* { dg-require-effective-target avx512vbmi } */
> 
>  #include "avx512f-helper.h"
> 
> There is no "#define AVX512VBM" added.
> 
>
My bad,

Patch below fixed avx512* tests.
No idea about cost-model ones.

---
 gcc/testsuite/gcc.target/i386/avx512ifma-vpmaddhuq-2.c      | 2 ++
 gcc/testsuite/gcc.target/i386/avx512ifma-vpmaddluq-2.c      | 2 ++
 gcc/testsuite/gcc.target/i386/avx512vbmi-vpermb-2.c         | 2 ++
 gcc/testsuite/gcc.target/i386/avx512vbmi-vpermi2b-2.c       | 2 ++
 gcc/testsuite/gcc.target/i386/avx512vbmi-vpermt2b-2.c       | 2 ++
 gcc/testsuite/gcc.target/i386/avx512vbmi-vpmultishiftqb-2.c | 2 ++
 6 files changed, 12 insertions(+)

Comments

H.J. Lu Dec. 1, 2014, 4:38 p.m. UTC | #1

On Mon, Dec 1, 2014 at 8:35 AM, Ilya Tocar <tocarip.intel@gmail.com> wrote:
>> > I saw
>> >
>> > FAIL: gcc.dg/vect/costmodel/i386/costmodel-fast-math-vect-pr29925.c
>> > scan-tree-dump-times vect "vectorized 1 loops" 1
>> > FAIL: gcc.dg/vect/costmodel/x86_64/costmodel-fast-math-vect-pr29925.c
>> > scan-tree-dump-times vect "vectorized 1 loops" 1
>> > FAIL: gcc.target/i386/avx256-unaligned-store-2.c scan-assembler
>> > vmovups.*\\\\*movv16qi_internal/3
>> > FAIL: gcc.target/i386/avx512ifma-vpmaddhuq-2.c (test for excess errors)
>> > UNRESOLVED: gcc.target/i386/avx512ifma-vpmaddhuq-2.c compilation
>> > failed to produce executable
>> > FAIL: gcc.target/i386/avx512ifma-vpmaddluq-2.c (test for excess errors)
>> > UNRESOLVED: gcc.target/i386/avx512ifma-vpmaddluq-2.c compilation
>> > failed to produce executable
>> > FAIL: gcc.target/i386/avx512vbmi-vpermb-2.c (test for excess errors)
>> > UNRESOLVED: gcc.target/i386/avx512vbmi-vpermb-2.c compilation failed
>> > to produce executable
>> > FAIL: gcc.target/i386/avx512vbmi-vpermi2b-2.c (test for excess errors)
>> > UNRESOLVED: gcc.target/i386/avx512vbmi-vpermi2b-2.c compilation failed
>> > to produce executable
>> > FAIL: gcc.target/i386/avx512vbmi-vpermt2b-2.c (test for excess errors)
>> > UNRESOLVED: gcc.target/i386/avx512vbmi-vpermt2b-2.c compilation failed
>> > to produce executable
>> > FAIL: gcc.target/i386/avx512vbmi-vpmultishiftqb-2.c (test for excess errors)
>> > UNRESOLVED: gcc.target/i386/avx512vbmi-vpmultishiftqb-2.c compilation
>> > failed to produce executable
>> >
>> > on x86:
>> >
>> > https://gcc.gnu.org/ml/gcc-testresults/2014-12/msg00030.html
>> >
>> >
>>
>> I took a look at one of them:
>>
>> diff --git a/gcc/testsuite/gcc.target/i386/avx512vbmi-vpmultishiftqb-2.c
>> b/gcc/testsuite/gcc.target/i386/avx512vbmi-vpmultishiftqb-2.c
>> index 936d938..861dce2 100644
>> --- a/gcc/testsuite/gcc.target/i386/avx512vbmi-vpmultishiftqb-2.c
>> +++ b/gcc/testsuite/gcc.target/i386/avx512vbmi-vpmultishiftqb-2.c
>> @@ -1,5 +1,5 @@
>>  /* { dg-do run } */
>> -/* { dg-options "-O2 -mavx512vbmi -DAVX512VBMI" } */
>> +/* { dg-options "-O2 -mavx512vbmi" } */
>>  /* { dg-require-effective-target avx512vbmi } */
>>
>>  #include "avx512f-helper.h"
>>
>> There is no "#define AVX512VBM" added.
>>
>>
> My bad,
>
> Patch below fixed avx512* tests.
> No idea about cost-model ones.
>
> ---
>  gcc/testsuite/gcc.target/i386/avx512ifma-vpmaddhuq-2.c      | 2 ++
>  gcc/testsuite/gcc.target/i386/avx512ifma-vpmaddluq-2.c      | 2 ++
>  gcc/testsuite/gcc.target/i386/avx512vbmi-vpermb-2.c         | 2 ++
>  gcc/testsuite/gcc.target/i386/avx512vbmi-vpermi2b-2.c       | 2 ++
>  gcc/testsuite/gcc.target/i386/avx512vbmi-vpermt2b-2.c       | 2 ++
>  gcc/testsuite/gcc.target/i386/avx512vbmi-vpmultishiftqb-2.c | 2 ++
>  6 files changed, 12 insertions(+)

This counts as obvious.  Please check it in with proper ChangeLog
entries.

diff --git a/gcc/testsuite/gcc.target/i386/avx512ifma-vpmaddhuq-2.c b/gcc/testsuite/gcc.target/i386/avx512ifma-vpmaddhuq-2.c
index 79f3da9..78af9d4 100644
--- a/gcc/testsuite/gcc.target/i386/avx512ifma-vpmaddhuq-2.c
+++ b/gcc/testsuite/gcc.target/i386/avx512ifma-vpmaddhuq-2.c
@@ -2,6 +2,8 @@ 
 /* { dg-options "-O2 -mavx512ifma" } */
 /* { dg-require-effective-target avx512ifma } */
 
+#define AVX512IFMA
+
 #include "avx512f-helper.h"
 
 #define SIZE (AVX512F_LEN / 64)
diff --git a/gcc/testsuite/gcc.target/i386/avx512ifma-vpmaddluq-2.c b/gcc/testsuite/gcc.target/i386/avx512ifma-vpmaddluq-2.c
index f6e4db1..ce38beb 100644
--- a/gcc/testsuite/gcc.target/i386/avx512ifma-vpmaddluq-2.c
+++ b/gcc/testsuite/gcc.target/i386/avx512ifma-vpmaddluq-2.c
@@ -2,6 +2,8 @@ 
 /* { dg-options "-O2 -mavx512ifma" } */
 /* { dg-require-effective-target avx512ifma } */
 
+#define AVX512IFMA
+
 #include "avx512f-helper.h"
 
 #define SIZE (AVX512F_LEN / 64)
diff --git a/gcc/testsuite/gcc.target/i386/avx512vbmi-vpermb-2.c b/gcc/testsuite/gcc.target/i386/avx512vbmi-vpermb-2.c
index 3027cf6..da1a22e 100644
--- a/gcc/testsuite/gcc.target/i386/avx512vbmi-vpermb-2.c
+++ b/gcc/testsuite/gcc.target/i386/avx512vbmi-vpermb-2.c
@@ -2,6 +2,8 @@ 
 /* { dg-options "-O2 -mavx512vbmi" } */
 /* { dg-require-effective-target avx512vbmi } */
 
+#define AVX512VBMI
+
 #include "avx512f-helper.h"
 
 #define SIZE (AVX512F_LEN / 8)
diff --git a/gcc/testsuite/gcc.target/i386/avx512vbmi-vpermi2b-2.c b/gcc/testsuite/gcc.target/i386/avx512vbmi-vpermi2b-2.c
index cb69fc5..31afc52 100644
--- a/gcc/testsuite/gcc.target/i386/avx512vbmi-vpermi2b-2.c
+++ b/gcc/testsuite/gcc.target/i386/avx512vbmi-vpermi2b-2.c
@@ -2,6 +2,8 @@ 
 /* { dg-options "-O2 -mavx512vbmi" } */
 /* { dg-require-effective-target avx512vbmi } */
 
+#define AVX512VBMI
+
 #include "avx512f-helper.h"
 
 #define SIZE (AVX512F_LEN / 8)
diff --git a/gcc/testsuite/gcc.target/i386/avx512vbmi-vpermt2b-2.c b/gcc/testsuite/gcc.target/i386/avx512vbmi-vpermt2b-2.c
index f6cb5b7..cc03426 100644
--- a/gcc/testsuite/gcc.target/i386/avx512vbmi-vpermt2b-2.c
+++ b/gcc/testsuite/gcc.target/i386/avx512vbmi-vpermt2b-2.c
@@ -2,6 +2,8 @@ 
 /* { dg-options "-O2 -mavx512vbmi" } */
 /* { dg-require-effective-target avx512vbmi } */
 
+#define AVX512VBMI
+
 #include "avx512f-helper.h"
 
 #define SIZE (AVX512F_LEN / 8)
diff --git a/gcc/testsuite/gcc.target/i386/avx512vbmi-vpmultishiftqb-2.c b/gcc/testsuite/gcc.target/i386/avx512vbmi-vpmultishiftqb-2.c
index 861dce2..0165d2e 100644
--- a/gcc/testsuite/gcc.target/i386/avx512vbmi-vpmultishiftqb-2.c
+++ b/gcc/testsuite/gcc.target/i386/avx512vbmi-vpmultishiftqb-2.c
@@ -2,6 +2,8 @@ 
 /* { dg-options "-O2 -mavx512vbmi" } */
 /* { dg-require-effective-target avx512vbmi } */
 
+#define AVX512VBMI
+
 #include "avx512f-helper.h"
 
 #define SIZE (AVX512F_LEN / 8)