diff mbox

[nft,3/5] tests: regression: fix "Listing is broken" instead of output mismatch

Message ID 1417434354-5782-3-git-send-email-pablo@netfilter.org
State Superseded
Delegated to: Pablo Neira
Headers show

Commit Message

Pablo Neira Ayuso Dec. 1, 2014, 11:45 a.m. UTC 
If the output string doesn't match the input, indicate that the output
mismatches instead of the misleading "Listing is broken".

Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
---
 tests/regression/nft-test.py |   15 ++++++---------
 1 file changed, 6 insertions(+), 9 deletions(-)
diff mbox

Patch

diff --git a/tests/regression/nft-test.py b/tests/regression/nft-test.py
index e1aec89..9998ab3 100755
--- a/tests/regression/nft-test.py
+++ b/tests/regression/nft-test.py
@@ -505,15 +505,12 @@  def rule_add(rule, table_list, chain_list, filename, lineno,
                                                         rule_output, cmd)
                                 if not force_all_family_option:
                                     return [ret, warning, error, unit_tests]
-                            if rule[0].find(rule_output.split(" ")[0]) > -1:
-                                warning += 1
-                                print_differences_warning(filename, lineno,
-                                                          rule[0], rule_output,
-                                                          cmd)
-                            else:
-                                error += 1
-                                print_differences_error(filename, lineno,
-                                                        rule_output, cmd)
+
+                            warning += 1
+                            print_differences_warning(filename, lineno,
+                                                      rule[0], rule_output,
+                                                      cmd)
+
                             if not force_all_family_option:
                                 return [ret, warning, error, unit_tests]