diff mbox

[3/3] package/lxc: disable broken toolchains on nios2

Message ID 1417366134-2098-3-git-send-email-bernd.kuhls@t-online.de
State Accepted
Commit a340b21300c0c59e68eec652e205473525d127f3
Headers show

Commit Message

Bernd Kuhls Nov. 30, 2014, 4:48 p.m. UTC
As discussed with Thomas
http://article.gmane.org/gmane.comp.lib.uclibc.buildroot/100998
only the current toolchains are broken:
"it's better to blacklist the individual toolchains that are known
to be broken, so that if we add another toolchain, we will be able
to see if the same bug happens as well or not."

Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
---
 package/lxc/Config.in |    7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

Comments

Yann E. MORIN Dec. 3, 2014, 6:31 p.m. UTC | #1
Bernd, All,

On 2014-11-30 17:48 +0100, Bernd Kuhls spake thusly:
> As discussed with Thomas
> http://article.gmane.org/gmane.comp.lib.uclibc.buildroot/100998
> only the current toolchains are broken:
> "it's better to blacklist the individual toolchains that are known
> to be broken, so that if we add another toolchain, we will be able
> to see if the same bug happens as well or not."
> 
> Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>

Acked-by: "Yann E. MORIN" <yann.morin.1998@free.fr>

Regards,
Yann E. MORIN.

> ---
>  package/lxc/Config.in |    7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/package/lxc/Config.in b/package/lxc/Config.in
> index cf85712..a90e58e 100644
> --- a/package/lxc/Config.in
> +++ b/package/lxc/Config.in
> @@ -6,7 +6,9 @@ config BR2_PACKAGE_LXC
>  	depends on BR2_LARGEFILE
>  	depends on BR2_USE_MMU # fork()
>  	depends on !BR2_avr32 # no timerfd
> -	depends on !BR2_nios2 # the toolchain doesn't support setns syscall
> +	# the toolchain doesn't support setns syscall
> +	depends on !BR2_TOOLCHAIN_EXTERNAL_CODESOURCERY_NIOSII201305
> +	depends on !BR2_TOOLCHAIN_EXTERNAL_CODESOURCERY_NIOSII201405
>  	depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_0 # libcap
>  	help
>  	  Linux Containers (LXC), provides the ability to group and isolate
> @@ -18,6 +20,7 @@ config BR2_PACKAGE_LXC
>  comment "lxc needs a toolchain w/ IPv6, threads, largefile, headers >= 3.0"
>  	depends on BR2_USE_MMU
>  	depends on !BR2_avr32 # no timerfd
> -	depends on !BR2_nios2 # the toolchain doesn't support setns syscall
> +	depends on !BR2_TOOLCHAIN_EXTERNAL_CODESOURCERY_NIOSII201305
> +	depends on !BR2_TOOLCHAIN_EXTERNAL_CODESOURCERY_NIOSII201405
>  	depends on !BR2_INET_IPV6 || !BR2_TOOLCHAIN_HAS_THREADS \
>                  || !BR2_LARGEFILE || !BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_0
> -- 
> 1.7.10.4
> 
> _______________________________________________
> buildroot mailing list
> buildroot@busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
diff mbox

Patch

diff --git a/package/lxc/Config.in b/package/lxc/Config.in
index cf85712..a90e58e 100644
--- a/package/lxc/Config.in
+++ b/package/lxc/Config.in
@@ -6,7 +6,9 @@  config BR2_PACKAGE_LXC
 	depends on BR2_LARGEFILE
 	depends on BR2_USE_MMU # fork()
 	depends on !BR2_avr32 # no timerfd
-	depends on !BR2_nios2 # the toolchain doesn't support setns syscall
+	# the toolchain doesn't support setns syscall
+	depends on !BR2_TOOLCHAIN_EXTERNAL_CODESOURCERY_NIOSII201305
+	depends on !BR2_TOOLCHAIN_EXTERNAL_CODESOURCERY_NIOSII201405
 	depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_0 # libcap
 	help
 	  Linux Containers (LXC), provides the ability to group and isolate
@@ -18,6 +20,7 @@  config BR2_PACKAGE_LXC
 comment "lxc needs a toolchain w/ IPv6, threads, largefile, headers >= 3.0"
 	depends on BR2_USE_MMU
 	depends on !BR2_avr32 # no timerfd
-	depends on !BR2_nios2 # the toolchain doesn't support setns syscall
+	depends on !BR2_TOOLCHAIN_EXTERNAL_CODESOURCERY_NIOSII201305
+	depends on !BR2_TOOLCHAIN_EXTERNAL_CODESOURCERY_NIOSII201405
 	depends on !BR2_INET_IPV6 || !BR2_TOOLCHAIN_HAS_THREADS \
                 || !BR2_LARGEFILE || !BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_0