| Message ID | 1417359787-10138-28-git-send-email-mst@redhat.com |
|---|---|
| State | Not Applicable, archived |
| Delegated to: | David Miller |
| Headers | show |
On Sun, 30 Nov 2014 17:11:30 +0200 "Michael S. Tsirkin" <mst@redhat.com> wrote: > Now that we have completed 1.0 support, enable it in our driver. > > Signed-off-by: Michael S. Tsirkin <mst@redhat.com> > --- > drivers/net/virtio_net.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c > index a0e64cf..c6a72d3 100644 > --- a/drivers/net/virtio_net.c > +++ b/drivers/net/virtio_net.c > @@ -2003,6 +2003,7 @@ static unsigned int features[] = { > VIRTIO_NET_F_GUEST_ANNOUNCE, VIRTIO_NET_F_MQ, > VIRTIO_NET_F_CTRL_MAC_ADDR, > VIRTIO_F_ANY_LAYOUT, > + VIRTIO_F_VERSION_1, > }; > > static struct virtio_driver virtio_net_driver = { Shouldn't you move this after the patch disabling mac address writing? -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, Dec 01, 2014 at 12:40:08PM +0100, Cornelia Huck wrote: > On Sun, 30 Nov 2014 17:11:30 +0200 > "Michael S. Tsirkin" <mst@redhat.com> wrote: > > > Now that we have completed 1.0 support, enable it in our driver. > > > > Signed-off-by: Michael S. Tsirkin <mst@redhat.com> > > --- > > drivers/net/virtio_net.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c > > index a0e64cf..c6a72d3 100644 > > --- a/drivers/net/virtio_net.c > > +++ b/drivers/net/virtio_net.c > > @@ -2003,6 +2003,7 @@ static unsigned int features[] = { > > VIRTIO_NET_F_GUEST_ANNOUNCE, VIRTIO_NET_F_MQ, > > VIRTIO_NET_F_CTRL_MAC_ADDR, > > VIRTIO_F_ANY_LAYOUT, > > + VIRTIO_F_VERSION_1, > > }; > > > > static struct virtio_driver virtio_net_driver = { > > Shouldn't you move this after the patch disabling mac address writing? Probably a good idea. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c index a0e64cf..c6a72d3 100644 --- a/drivers/net/virtio_net.c +++ b/drivers/net/virtio_net.c @@ -2003,6 +2003,7 @@ static unsigned int features[] = { VIRTIO_NET_F_GUEST_ANNOUNCE, VIRTIO_NET_F_MQ, VIRTIO_NET_F_CTRL_MAC_ADDR, VIRTIO_F_ANY_LAYOUT, + VIRTIO_F_VERSION_1, }; static struct virtio_driver virtio_net_driver = {
Now that we have completed 1.0 support, enable it in our driver. Signed-off-by: Michael S. Tsirkin <mst@redhat.com> --- drivers/net/virtio_net.c | 1 + 1 file changed, 1 insertion(+)