diff mbox

[PATCHv3,07/74] portmap: use <pkg>_INSTALL_INIT_SYSV mechanism

Message ID 1417357142-14307-8-git-send-email-thomas.petazzoni@free-electrons.com
State Accepted
Headers show

Commit Message

Thomas Petazzoni Nov. 30, 2014, 2:17 p.m. UTC
We also switch to using a full destination path as the second argument
of $(INSTALL).

Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
---
 package/portmap/portmap.mk | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

Comments

Yann E. MORIN Nov. 30, 2014, 2:56 p.m. UTC | #1
Thomas, All,

On 2014-11-30 15:17 +0100, Thomas Petazzoni spake thusly:
> We also switch to using a full destination path as the second argument
> of $(INSTALL).
> 
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> ---
>  package/portmap/portmap.mk | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/package/portmap/portmap.mk b/package/portmap/portmap.mk
> index 0189597..dd60809 100644
> --- a/package/portmap/portmap.mk
> +++ b/package/portmap/portmap.mk
> @@ -30,8 +30,10 @@ define PORTMAP_INSTALL_TARGET_CMDS
>  		$(TARGET_DIR)/usr/share/man/man8/pmap_dump.8
>  	$(INSTALL) -D $(@D)/pmap_set.8 \
>  		$(TARGET_DIR)/usr/share/man/man8/pmap_set.8
> -	$(INSTALL) -m 0755 package/portmap/S13portmap \
> -		$(TARGET_DIR)/etc/init.d
> +endef
> +
> +define PORTMAP_INSTALL_INIT_SYSV
> +	$(INSTALL) -m 0755 package/portmap/S13portmap $(TARGET_DIR)/etc/init.d/S13portmap

Missing -D option.

Regards,
Yann E. MORIN.

>  endef
>  
>  $(eval $(generic-package))
> -- 
> 2.1.0
> 
> _______________________________________________
> buildroot mailing list
> buildroot@busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
Peter Korsgaard Dec. 1, 2014, 9:42 p.m. UTC | #2
>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:

 > We also switch to using a full destination path as the second argument
 > of $(INSTALL).

 > Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
 > ---
 >  package/portmap/portmap.mk | 6 ++++--
 >  1 file changed, 4 insertions(+), 2 deletions(-)

 > diff --git a/package/portmap/portmap.mk b/package/portmap/portmap.mk
 > index 0189597..dd60809 100644
 > --- a/package/portmap/portmap.mk
 > +++ b/package/portmap/portmap.mk
 > @@ -30,8 +30,10 @@ define PORTMAP_INSTALL_TARGET_CMDS
 >  		$(TARGET_DIR)/usr/share/man/man8/pmap_dump.8
 >  	$(INSTALL) -D $(@D)/pmap_set.8 \
 >  		$(TARGET_DIR)/usr/share/man/man8/pmap_set.8
 > -	$(INSTALL) -m 0755 package/portmap/S13portmap \
 > -		$(TARGET_DIR)/etc/init.d
 > +endef
 > +
 > +define PORTMAP_INSTALL_INIT_SYSV
 > +	$(INSTALL) -m 0755 package/portmap/S13portmap $(TARGET_DIR)/etc/init.d/S13portmap
 >  endef

Committed with the -D option added, thanks.
diff mbox

Patch

diff --git a/package/portmap/portmap.mk b/package/portmap/portmap.mk
index 0189597..dd60809 100644
--- a/package/portmap/portmap.mk
+++ b/package/portmap/portmap.mk
@@ -30,8 +30,10 @@  define PORTMAP_INSTALL_TARGET_CMDS
 		$(TARGET_DIR)/usr/share/man/man8/pmap_dump.8
 	$(INSTALL) -D $(@D)/pmap_set.8 \
 		$(TARGET_DIR)/usr/share/man/man8/pmap_set.8
-	$(INSTALL) -m 0755 package/portmap/S13portmap \
-		$(TARGET_DIR)/etc/init.d
+endef
+
+define PORTMAP_INSTALL_INIT_SYSV
+	$(INSTALL) -m 0755 package/portmap/S13portmap $(TARGET_DIR)/etc/init.d/S13portmap
 endef
 
 $(eval $(generic-package))