diff mbox

[PATCHv3,04/74] radvd: use <pkg>_INSTALL_INIT_SYSV

Message ID 1417357142-14307-5-git-send-email-thomas.petazzoni@free-electrons.com
State Accepted
Headers show

Commit Message

Thomas Petazzoni Nov. 30, 2014, 2:17 p.m. UTC
This commit changes the radvd to use the <pkg>_INSTALL_INIT_SYSV
mechanism instead of using a post install target hook. We also use a
full destination path when calling $(INSTALL).

Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
---
 package/radvd/radvd.mk | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

Comments

Yann E. MORIN Nov. 30, 2014, 2:47 p.m. UTC | #1
Thomas, All,

On 2014-11-30 15:17 +0100, Thomas Petazzoni spake thusly:
> This commit changes the radvd to use the <pkg>_INSTALL_INIT_SYSV
> mechanism instead of using a post install target hook. We also use a
> full destination path when calling $(INSTALL).
> 
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>

Acked-by: "Yann E. MORIN" <yann.morin.1998@free.fr>

Regards,
Yann E. MORIN.

> ---
>  package/radvd/radvd.mk | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/package/radvd/radvd.mk b/package/radvd/radvd.mk
> index e0d4f69..e65d74a 100644
> --- a/package/radvd/radvd.mk
> +++ b/package/radvd/radvd.mk
> @@ -12,10 +12,8 @@ RADVD_CONF_ENV = ac_cv_prog_cc_c99='-std=gnu99'
>  # For radvd-01-drop-check.patch & radvd-02-drop-stack-protector.patch
>  RADVD_AUTORECONF = YES
>  
> -define RADVD_INSTALL_INITSCRIPT
> -	$(INSTALL) -m 0755 package/radvd/S50radvd $(TARGET_DIR)/etc/init.d
> +define RADVD_INSTALL_INIT_SYSV
> +	$(INSTALL) -D -m 0755 package/radvd/S50radvd $(TARGET_DIR)/etc/init.d/S50radvd
>  endef
>  
> -RADVD_POST_INSTALL_TARGET_HOOKS += RADVD_INSTALL_INITSCRIPT
> -
>  $(eval $(autotools-package))
> -- 
> 2.1.0
> 
> _______________________________________________
> buildroot mailing list
> buildroot@busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
Peter Korsgaard Dec. 1, 2014, 9:36 p.m. UTC | #2
>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:

 > This commit changes the radvd to use the <pkg>_INSTALL_INIT_SYSV
 > mechanism instead of using a post install target hook. We also use a
 > full destination path when calling $(INSTALL).

 > Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>

Committed, thanks.
diff mbox

Patch

diff --git a/package/radvd/radvd.mk b/package/radvd/radvd.mk
index e0d4f69..e65d74a 100644
--- a/package/radvd/radvd.mk
+++ b/package/radvd/radvd.mk
@@ -12,10 +12,8 @@  RADVD_CONF_ENV = ac_cv_prog_cc_c99='-std=gnu99'
 # For radvd-01-drop-check.patch & radvd-02-drop-stack-protector.patch
 RADVD_AUTORECONF = YES
 
-define RADVD_INSTALL_INITSCRIPT
-	$(INSTALL) -m 0755 package/radvd/S50radvd $(TARGET_DIR)/etc/init.d
+define RADVD_INSTALL_INIT_SYSV
+	$(INSTALL) -D -m 0755 package/radvd/S50radvd $(TARGET_DIR)/etc/init.d/S50radvd
 endef
 
-RADVD_POST_INSTALL_TARGET_HOOKS += RADVD_INSTALL_INITSCRIPT
-
 $(eval $(autotools-package))