Patchwork [2/2] ide: add __init/__exit macros to drivers/ide/scc_pata.c

login
register
mail settings
Submitter Peter Hüwe
Date Dec. 22, 2009, 8:29 a.m.
Message ID <1261470564-23754-2-git-send-email-peterhuewe@gmx.de>
Download mbox | patch
Permalink /patch/41597/
State Superseded
Delegated to: David Miller
Headers show

Comments

Peter Hüwe - Dec. 22, 2009, 8:29 a.m.
From: Peter Huewe <peterhuewe@gmx.de>

Trivial patch which adds the __init/__exit macros to the module_init/
module_exit functions of

drivers/ide/scc_pata.c

Please have a look at the small patch and either pull it through
your tree, or please ack' it so Jiri can pull it through the trivial
tree.

Patch against linux-next-tree, 22. Dez 08:38:18 CET 2009
but also present in linus tree.

Signed-off-by: Peter Huewe <peterhuewe@gmx.de>
---
 drivers/ide/scc_pata.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
Jiri Kosina - Jan. 5, 2010, 10:25 a.m.
On Tue, 22 Dec 2009, peterhuewe@gmx.de wrote:

> From: Peter Huewe <peterhuewe@gmx.de>
> 
> Trivial patch which adds the __init/__exit macros to the module_init/
> module_exit functions of
> 
> drivers/ide/scc_pata.c
> 
> Please have a look at the small patch and either pull it through
> your tree, or please ack' it so Jiri can pull it through the trivial
> tree.
> 
> Patch against linux-next-tree, 22. Dez 08:38:18 CET 2009
> but also present in linus tree.
> 
> Signed-off-by: Peter Huewe <peterhuewe@gmx.de>
> ---
>  drivers/ide/scc_pata.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/ide/scc_pata.c b/drivers/ide/scc_pata.c
> index 1104bb3..58c9c91 100644
> --- a/drivers/ide/scc_pata.c
> +++ b/drivers/ide/scc_pata.c
> @@ -872,14 +872,14 @@ static struct pci_driver scc_pci_driver = {
>  	.remove = __devexit_p(scc_remove),
>  };
>  
> -static int scc_ide_init(void)
> +static int __init scc_ide_init(void)
>  {
>  	return ide_pci_register_driver(&scc_pci_driver);
>  }
>  
>  module_init(scc_ide_init);
>  /* -- No exit code?
> -static void scc_ide_exit(void)
> +static void __exit scc_ide_exit(void)
>  {
>  	ide_pci_unregister_driver(&scc_pci_driver);
>  }

This code is commented out anyway. So we should either nuke it out 
completely if it is not needed, or uncomment and fix.

Bartlomiej, David?

Patch

diff --git a/drivers/ide/scc_pata.c b/drivers/ide/scc_pata.c
index 1104bb3..58c9c91 100644
--- a/drivers/ide/scc_pata.c
+++ b/drivers/ide/scc_pata.c
@@ -872,14 +872,14 @@  static struct pci_driver scc_pci_driver = {
 	.remove = __devexit_p(scc_remove),
 };
 
-static int scc_ide_init(void)
+static int __init scc_ide_init(void)
 {
 	return ide_pci_register_driver(&scc_pci_driver);
 }
 
 module_init(scc_ide_init);
 /* -- No exit code?
-static void scc_ide_exit(void)
+static void __exit scc_ide_exit(void)
 {
 	ide_pci_unregister_driver(&scc_pci_driver);
 }