From patchwork Thu Nov 27 20:42:24 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joseph Myers X-Patchwork-Id: 415633 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id AA7F1140188 for ; Fri, 28 Nov 2014 07:42:35 +1100 (AEDT) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:date:from:to:subject:message-id:mime-version :content-type; q=dns; s=default; b=lfpFuikXOkPI2wTxMFMArdGqpDQGH OQpvZcRT+4y/cYBj4f+Z6ASAfAQV7B8dSHgFqWA2VWcXdo0iSqR63km2jE3TTav0 UEwle4C2u4QXCslItw07/FggBB0q2VIKi+0ZncZTB2ctizP4uMqsnJJgNZSQEXKc 5GlGGHtWFFY+qk= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:date:from:to:subject:message-id:mime-version :content-type; s=default; bh=2Oeg8XBlM+SPOpPxnVkNSrS9EXU=; b=vEO CYcdVPgoonkEqs4IDn7JoH+DyimNvis+d4pYaoaCauPyB5UdJUd7ny+1wP9FuQZa DnxYp0XfBcr+rtz4QFrxf8z2HTxeGrnNrjKiYIb0iZKbT1g4tSmG+8aSmrHeHTAY vsEXag4js6t1oG1dEUq3eYus/2qQZgAgXfbGsh+g= Received: (qmail 426 invoked by alias); 27 Nov 2014 20:42:30 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 416 invoked by uid 89); 27 Nov 2014 20:42:29 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL, BAYES_00, RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.2 X-HELO: relay1.mentorg.com Date: Thu, 27 Nov 2014 20:42:24 +0000 From: Joseph Myers To: Subject: Add more headers to include/ for conform tests Message-ID: User-Agent: Alpine 2.10 (DEB 1266 2009-07-14) MIME-Version: 1.0 Carlos reported failures in conform/ tests in environments where the compiler used could only find headers in glibc's source and build trees, not any previously installed headers . This patch adds wrappers for the affected headers to include/, which is the normal way to make headers visible when building or testing in directories other than the one containing the header (I suppose these headers weren't needed in any such directories except conform/, or other build or test failures would have resulted). I believe the same issue applies at least to regexp.h and re_comp.h - we don't currently have conform/ expectations for those, but when such expectations are added we'll also need to add header wrappers. The semaphore.h wrapper just includes nptl/semaphore.h - there's a question about whether this is logically correct, given the possibility of other thread library implementations. I suggested a couple of possible alternative approaches in . Tested for x86_64 (testsuite, and that installed stripped shared libraries are unchanged by the patch). I did *not* test a configuration such as that in which Carlos saw failure. 2014-11-27 Joseph Myers * include/cpio.h: New file. * include/fmtmsg.h: Likewise. * include/semaphore.h: Likewise. diff --git a/include/cpio.h b/include/cpio.h new file mode 100644 index 0000000..38e2ed1 --- /dev/null +++ b/include/cpio.h @@ -0,0 +1 @@ +#include diff --git a/include/fmtmsg.h b/include/fmtmsg.h new file mode 100644 index 0000000..6ac606d --- /dev/null +++ b/include/fmtmsg.h @@ -0,0 +1 @@ +#include diff --git a/include/semaphore.h b/include/semaphore.h new file mode 100644 index 0000000..01c7ba1 --- /dev/null +++ b/include/semaphore.h @@ -0,0 +1 @@ +#include