From patchwork Mon Dec 21 19:23:58 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexander Strakh X-Patchwork-Id: 41554 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 12E96B6F0A for ; Tue, 22 Dec 2009 02:19:25 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753096AbZLUPSu (ORCPT ); Mon, 21 Dec 2009 10:18:50 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753041AbZLUPSt (ORCPT ); Mon, 21 Dec 2009 10:18:49 -0500 Received: from smtp.ispras.ru ([83.149.198.201]:48696 "EHLO smtp.ispras.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752340AbZLUPSs (ORCPT ); Mon, 21 Dec 2009 10:18:48 -0500 Received: from ispserv.ispras.ru (ispserv.ispras.ru [83.149.198.72]) by smtp.ispras.ru (Postfix) with ESMTP id 48E0F5D40AE; Mon, 21 Dec 2009 17:38:15 +0300 (MSK) Received: from pamir.localnet (winnie.ispras.ru [83.149.198.236]) by ispserv.ispras.ru (Postfix) with ESMTP id 330F33FC48; Mon, 21 Dec 2009 18:18:47 +0300 (MSK) From: Alexander Strakh Organization: ISP RAS To: Bartlomiej Zolnierkiewicz , Donald Becker , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] 3c507.c: remove unused NULL pointer check Date: Mon, 21 Dec 2009 19:23:58 +0000 User-Agent: KMail/1.12.2 (Linux/2.6.31.5-0.1-desktop; KDE/4.3.1; x86_64; ; ) MIME-Version: 1.0 Message-Id: <200912211923.58735.strakh@ispras.ru> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org In driver drivers/net/3c507.c in function Iirqreturn_t el16_interrupt: 1. If in line 555 dev = NULL then we goto line 556 2. In line 556 we have null dereference because pr_err called with dev->name in third parameter. 555 if (dev == NULL) { 556 pr_err("%s: net_interrupt(): irq %d for unknown device. \n", 557 dev->name, irq); 558 return IRQ_NONE; 559 } Found by Linux Device Drivers Verification (Svace detector) Remove unused NULL pointer check. Signed-off-by: Alexander Strakh --- -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/./0000/drivers/net/3c507.c b/./moder/drivers/net/3c507.c index fbc2311..3bfb3dd 100644 --- a/./0000/drivers/net/3c507.c +++ b/./moder/drivers/net/3c507.c @@ -552,12 +552,6 @@ static irqreturn_t el16_interrupt(int irq, void *dev_id) ushort ack_cmd = 0; void __iomem *shmem; - if (dev == NULL) { - pr_err("%s: net_interrupt(): irq %d for unknown device.\n", - dev->name, irq); - return IRQ_NONE; - } - ioaddr = dev->base_addr; lp = netdev_priv(dev); shmem = lp->base;