| Message ID | 1417094496-28740-1-git-send-email-human.hwang@samsung.com |
|---|---|
| State | Changes Requested |
| Delegated to: | Minkyu Kang |
| Headers | show |
Hey Hyungwon, The following are some of the patches i had locally on top of your v9 Odroid. Feel free to merge them into your patchset (or squash them into your existing patches) if they look good to you. Sjoerd Simons (4): Odroid-XU3: Drop redundant fields Odroid-XU3: Add entry for DTS EHCI GPIO ODROID-XU3: Make odroid-xu3 an smdk5420 variant ODROID-XU3: drop overriding the boot environment arch/arm/cpu/armv7/exynos/Kconfig | 1 - arch/arm/dts/exynos5422-odroidxu3.dts | 16 ++--- board/samsung/odroid-xu3/Kconfig | 12 ---- board/samsung/odroid-xu3/MAINTAINERS | 6 -- board/samsung/odroid-xu3/Makefile | 7 -- board/samsung/odroid-xu3/odroid-xu3.c | 122 ---------------------------------- board/samsung/odroid-xu3/setup.h | 95 -------------------------- board/samsung/smdk5420/Kconfig | 13 ++++ include/configs/odroid_xu3.h | 72 -------------------- 9 files changed, 17 insertions(+), 327 deletions(-) delete mode 100644 board/samsung/odroid-xu3/Kconfig delete mode 100644 board/samsung/odroid-xu3/MAINTAINERS delete mode 100644 board/samsung/odroid-xu3/Makefile delete mode 100644 board/samsung/odroid-xu3/odroid-xu3.c delete mode 100644 board/samsung/odroid-xu3/setup.h
Dear Sjoerd, Thanks for this work. I think it is better to squash patch #1, #3, #4 into my patchs, because these patches remove the code which needlessly being added by my patches. I will include patch #2 also from next version. On Mon, 01 Dec 2014 13:34:16 +0100 Sjoerd Simons <sjoerd.simons@collabora.co.uk> wrote: > Hey Hyungwon, > > The following are some of the patches i had locally on top of your v9 > Odroid. Feel free to merge them into your patchset (or squash them > into your existing patches) if they look good to you. > > Sjoerd Simons (4): > Odroid-XU3: Drop redundant fields > Odroid-XU3: Add entry for DTS EHCI GPIO > ODROID-XU3: Make odroid-xu3 an smdk5420 variant > ODROID-XU3: drop overriding the boot environment > > arch/arm/cpu/armv7/exynos/Kconfig | 1 - > arch/arm/dts/exynos5422-odroidxu3.dts | 16 ++--- > board/samsung/odroid-xu3/Kconfig | 12 ---- > board/samsung/odroid-xu3/MAINTAINERS | 6 -- > board/samsung/odroid-xu3/Makefile | 7 -- > board/samsung/odroid-xu3/odroid-xu3.c | 122 > ---------------------------------- > board/samsung/odroid-xu3/setup.h | 95 > -------------------------- board/samsung/smdk5420/Kconfig | > 13 ++++ include/configs/odroid_xu3.h | 72 > -------------------- 9 files changed, 17 insertions(+), 327 > deletions(-) delete mode 100644 board/samsung/odroid-xu3/Kconfig > delete mode 100644 board/samsung/odroid-xu3/MAINTAINERS delete mode > 100644 board/samsung/odroid-xu3/Makefile delete mode 100644 > board/samsung/odroid-xu3/odroid-xu3.c delete mode 100644 > board/samsung/odroid-xu3/setup.h > Best regards, Hyungwon Hwang
Hi, On 12/02/2014 10:56 AM, Hyungwon Hwang wrote: > Dear Sjoerd, > > Thanks for this work. I think it is better to squash patch #1, #3, #4 > into my patchs, because these patches remove the code which needlessly > being added by my patches. I will include patch #2 also from next > version. > > On Mon, 01 Dec 2014 13:34:16 +0100 > Sjoerd Simons <sjoerd.simons@collabora.co.uk> wrote: > >> Hey Hyungwon, >> >> The following are some of the patches i had locally on top of your v9 >> Odroid. Feel free to merge them into your patchset (or squash them >> into your existing patches) if they look good to you. >> >> Sjoerd Simons (4): >> Odroid-XU3: Drop redundant fields >> Odroid-XU3: Add entry for DTS EHCI GPIO >> ODROID-XU3: Make odroid-xu3 an smdk5420 variant I need to support odroid xu3 specific gpio setting e.g. to reset emmc for reset command support. Also there are specific gpio setting codes for only smdk5420 board on board/samsung/smdk5420/smdk5420.c and they are not related with odroid xu3 board. So, i think that need to split them. First, split board file. It's easiest way to make separate board directory. Second, we can make just board file for odroid xu3 in same directory and we should distinguish them from Makefile but i don't know this is general way. Third, using same board file like now but we will need any way to distinguish boards on runtime. Any ideas? Thanks. >> ODROID-XU3: drop overriding the boot environment >> >> arch/arm/cpu/armv7/exynos/Kconfig | 1 - >> arch/arm/dts/exynos5422-odroidxu3.dts | 16 ++--- >> board/samsung/odroid-xu3/Kconfig | 12 ---- >> board/samsung/odroid-xu3/MAINTAINERS | 6 -- >> board/samsung/odroid-xu3/Makefile | 7 -- >> board/samsung/odroid-xu3/odroid-xu3.c | 122 >> ---------------------------------- >> board/samsung/odroid-xu3/setup.h | 95 >> -------------------------- board/samsung/smdk5420/Kconfig | >> 13 ++++ include/configs/odroid_xu3.h | 72 >> -------------------- 9 files changed, 17 insertions(+), 327 >> deletions(-) delete mode 100644 board/samsung/odroid-xu3/Kconfig >> delete mode 100644 board/samsung/odroid-xu3/MAINTAINERS delete mode >> 100644 board/samsung/odroid-xu3/Makefile delete mode 100644 >> board/samsung/odroid-xu3/odroid-xu3.c delete mode 100644 >> board/samsung/odroid-xu3/setup.h >> > > Best regards, > Hyungwon Hwang > _______________________________________________ > U-Boot mailing list > U-Boot@lists.denx.de > http://lists.denx.de/mailman/listinfo/u-boot >
On Wed, 2015-01-07 at 17:31 +0900, Joonyoung Shim wrote: > Hi, > > On 12/02/2014 10:56 AM, Hyungwon Hwang wrote: > > Dear Sjoerd, > > > > Thanks for this work. I think it is better to squash patch #1, #3, #4 > > into my patchs, because these patches remove the code which needlessly > > being added by my patches. I will include patch #2 also from next > > version. > > > > On Mon, 01 Dec 2014 13:34:16 +0100 > > Sjoerd Simons <sjoerd.simons@collabora.co.uk> wrote: > > > >> Hey Hyungwon, > >> > >> The following are some of the patches i had locally on top of your v9 > >> Odroid. Feel free to merge them into your patchset (or squash them > >> into your existing patches) if they look good to you. > >> > >> Sjoerd Simons (4): > >> Odroid-XU3: Drop redundant fields > >> Odroid-XU3: Add entry for DTS EHCI GPIO > >> ODROID-XU3: Make odroid-xu3 an smdk5420 variant > > I need to support odroid xu3 specific gpio setting e.g. to reset emmc > for reset command support. Also there are specific gpio setting codes > for only smdk5420 board on board/samsung/smdk5420/smdk5420.c and they > are not related with odroid xu3 board. > > So i think that need to split them. For the gpio specific to the smdk5420 are you referring to the usb vbus gpio ? (For which i've dropped the code in a later, merged commit as it's handled by common code). > First, split board file. It's easiest way to make separate board > directory. > > Second, we can make just board file for odroid xu3 in same directory and > we should distinguish them from Makefile but i don't know this is > general way. > > Third, using same board file like now but we will need any way to > distinguish boards on runtime. To distinguish boards at runtime you should use the information from the DT file of the board rather then hardcoding it in a board file.
Hi Sjoerd, On 01/07/2015 06:25 PM, Sjoerd Simons wrote: > On Wed, 2015-01-07 at 17:31 +0900, Joonyoung Shim wrote: >> Hi, >> >> On 12/02/2014 10:56 AM, Hyungwon Hwang wrote: >>> Dear Sjoerd, >>> >>> Thanks for this work. I think it is better to squash patch #1, #3, #4 >>> into my patchs, because these patches remove the code which needlessly >>> being added by my patches. I will include patch #2 also from next >>> version. >>> >>> On Mon, 01 Dec 2014 13:34:16 +0100 >>> Sjoerd Simons <sjoerd.simons@collabora.co.uk> wrote: >>> >>>> Hey Hyungwon, >>>> >>>> The following are some of the patches i had locally on top of your v9 >>>> Odroid. Feel free to merge them into your patchset (or squash them >>>> into your existing patches) if they look good to you. >>>> >>>> Sjoerd Simons (4): >>>> Odroid-XU3: Drop redundant fields >>>> Odroid-XU3: Add entry for DTS EHCI GPIO >>>> ODROID-XU3: Make odroid-xu3 an smdk5420 variant >> >> I need to support odroid xu3 specific gpio setting e.g. to reset emmc >> for reset command support. Also there are specific gpio setting codes >> for only smdk5420 board on board/samsung/smdk5420/smdk5420.c and they >> are not related with odroid xu3 board. >> >> So i think that need to split them. > > For the gpio specific to the smdk5420 are you referring to the usb vbus > gpio ? (For which i've dropped the code in a later, merged commit as > it's handled by common code). I just mean current remaining - lcd and pwm codes, but maybe can move them to device tree. > >> First, split board file. It's easiest way to make separate board >> directory. >> >> Second, we can make just board file for odroid xu3 in same directory and >> we should distinguish them from Makefile but i don't know this is >> general way. >> >> Third, using same board file like now but we will need any way to >> distinguish boards on runtime. > > To distinguish boards at runtime you should use the information from the > DT file of the board rather then hardcoding it in a board file. > OK, let's try to use device tree. Thanks for guide.
diff --git a/include/configs/exynos5-common.h b/include/configs/exynos5-common.h index ba591e7..437eaae 100644 --- a/include/configs/exynos5-common.h +++ b/include/configs/exynos5-common.h @@ -109,7 +109,7 @@ #define CONFIG_SYS_MONITOR_BASE 0x00000000 -#define CONFIG_SYS_MMC_ENV_DEV 0 +#define CONFIG_SYS_MMC_ENV_DEV 1 #define CONFIG_SECURE_BL1_ONLY diff --git a/include/configs/odroid_xu3.h b/include/configs/odroid_xu3.h index cda4f26..b46ccad 100644 --- a/include/configs/odroid_xu3.h +++ b/include/configs/odroid_xu3.h @@ -110,15 +110,15 @@ "run kernel_args;" \ "bootz ${kerneladdr} ${initrd_addr} ${fdt_addr};\0" \ "autoboot=" \ - "if test -e mmc 0 Image.itb; then; " \ + "if test -e mmc 1 Image.itb; then; " \ "run boot_fit;" \ - "elif test -e mmc 0 zImage; then; " \ + "elif test -e mmc 1 zImage; then; " \ "run boot_zimg;" \ - "elif test -e mmc 0 uImage; then; " \ + "elif test -e mmc 1 uImage; then; " \ "run boot_uimg;" \ "fi;\0" \ "console=" CONFIG_DEFAULT_CONSOLE \ - "mmcbootdev=0\0" \ + "mmcbootdev=1\0" \ "mmcbootpart=1\0" \ "mmcrootdev=0\0" \ "mmcrootpart=2\0" \