Patchwork ethtool: Do not report link partner advertising flags if set to 0

login
register
mail settings
Submitter Ben Hutchings
Date Dec. 20, 2009, 7:12 p.m.
Message ID <1261336350.25157.200.camel@localhost>
Download mbox | patch
Permalink /patch/41515/
State Not Applicable
Delegated to: David Miller
Headers show

Comments

Ben Hutchings - Dec. 20, 2009, 7:12 p.m.
Only some drivers (and none before kernel version 2.6.31) currently
set these flags.  When the flags are equal to 0 and so we don't know
what the link partner advertised, don't report anything.

Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
---
 ethtool.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)
Jeff Garzik - Dec. 20, 2009, 8:34 p.m.
On 12/20/2009 02:12 PM, Ben Hutchings wrote:
> Only some drivers (and none before kernel version 2.6.31) currently
> set these flags.  When the flags are equal to 0 and so we don't know
> what the link partner advertised, don't report anything.
>
> Signed-off-by: Ben Hutchings<ben@decadent.org.uk>
> ---
>   ethtool.c |    4 +++-
>   1 files changed, 3 insertions(+), 1 deletions(-)

applied


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/ethtool.c b/ethtool.c
index 10dfc80..298b690 100644
--- a/ethtool.c
+++ b/ethtool.c
@@ -948,7 +948,9 @@  static int dump_ecmd(struct ethtool_cmd *ep)
 
 	dump_supported(ep);
 	dump_advertised(ep, "Advertised", ep->advertising);
-	dump_advertised(ep, "Link partner advertised", ep->lp_advertising);
+	if (ep->lp_advertising)
+		dump_advertised(ep, "Link partner advertised",
+				ep->lp_advertising);
 
 	fprintf(stdout, "	Speed: ");
 	speed = ethtool_cmd_speed(ep);