| Message ID | 1416921892-4756-4-git-send-email-yangyingliang@huawei.com |
|---|---|
| State | Rejected, archived |
| Delegated to: | David Miller |
| Headers | show |
On Tue, 2014-11-25 at 21:24 +0800, Yang Yingliang wrote: > If a GSO packet cost more than 125ms to send, segment the > packet and send individual segments. > > Signed-off-by: Yang Yingliang <yangyingliang@huawei.com> > --- > net/sched/sch_fq.c | 24 ++++++++++++++++++++++++ > 1 file changed, 24 insertions(+) > > diff --git a/net/sched/sch_fq.c b/net/sched/sch_fq.c > index ec6eff8..0119340 100644 > --- a/net/sched/sch_fq.c > +++ b/net/sched/sch_fq.c > @@ -423,6 +423,30 @@ static int fq_enqueue(struct sk_buff *skb, struct Qdisc *sch) > return qdisc_drop(skb, sch); > } > I am opposed to this patch serie. FQ is used at 40Gb speeds at Google, we can not afford doing such copies in FQ at all. If you believe packets are too big at this point, then you should fix the provider of such packets. Sorry. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/net/sched/sch_fq.c b/net/sched/sch_fq.c index ec6eff8..0119340 100644 --- a/net/sched/sch_fq.c +++ b/net/sched/sch_fq.c @@ -423,6 +423,30 @@ static int fq_enqueue(struct sk_buff *skb, struct Qdisc *sch) return qdisc_drop(skb, sch); } + if (skb_is_gso(skb) && skb_is_too_big(skb, q, NULL)) { + struct sk_buff *segs, *nskb; + netdev_features_t features = netif_skb_features(skb); + int nb = 0; + + segs = skb_gso_segment(skb, features & ~NETIF_F_GSO_MASK); + + if (IS_ERR_OR_NULL(segs)) + goto enqueue_out; + + while (segs) { + nskb = segs->next; + qdisc_skb_cb(segs)->pkt_len = segs->len; + __fq_enqueue(segs, sch, f); + nb++; + segs = nskb; + } + if (nb > 1) + qdisc_tree_decrease_qlen(sch, 1 - nb); + consume_skb(skb); + return NET_XMIT_SUCCESS; + } + +enqueue_out: return __fq_enqueue(skb, sch, f); }
If a GSO packet cost more than 125ms to send, segment the packet and send individual segments. Signed-off-by: Yang Yingliang <yangyingliang@huawei.com> --- net/sched/sch_fq.c | 24 ++++++++++++++++++++++++ 1 file changed, 24 insertions(+)