| Message ID | 1416911328-10979-15-git-send-email-jiri@resnulli.us |
|---|---|
| State | Changes Requested, archived |
| Delegated to: | David Miller |
| Headers | show |
On 11/25/14, 2:28 AM, Jiri Pirko wrote: > From: Scott Feldman <sfeldma@gmail.com> > > This policy flag controls syncing of learned FDB entries to bridge's FDB. If > on, FDB entries learned on bridge port device will be synced. If off, device > may still learn new FDB entries but they will not be synced with bridge's FDB. > > Signed-off-by: Scott Feldman <sfeldma@gmail.com> > Signed-off-by: Jiri Pirko <jiri@resnulli.us> Acked-by: Roopa Prabhu<roopa@cumulusnetworks.com> > --- > new in v3 > --- > include/linux/if_bridge.h | 1 + > include/uapi/linux/if_link.h | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/include/linux/if_bridge.h b/include/linux/if_bridge.h > index b4bb104..67b7a8e 100644 > --- a/include/linux/if_bridge.h > +++ b/include/linux/if_bridge.h > @@ -42,6 +42,7 @@ struct br_ip_list { > #define BR_AUTO_MASK (BR_FLOOD | BR_LEARNING) > #define BR_PROMISC 0x00000080 > #define BR_PROXYARP 0x00000100 > +#define BR_LEARNING_SYNC 0x00000200 > > extern void brioctl_set(int (*ioctl_hook)(struct net *, unsigned int, void __user *)); > > diff --git a/include/uapi/linux/if_link.h b/include/uapi/linux/if_link.h > index 4163753..d8e6a31 100644 > --- a/include/uapi/linux/if_link.h > +++ b/include/uapi/linux/if_link.h > @@ -245,6 +245,7 @@ enum { > IFLA_BRPORT_LEARNING, /* mac learning */ > IFLA_BRPORT_UNICAST_FLOOD, /* flood unicast traffic */ > IFLA_BRPORT_PROXYARP, /* proxy ARP */ > + IFLA_BRPORT_LEARNING_SYNC, /* mac learning sync from device */ > __IFLA_BRPORT_MAX > }; > #define IFLA_BRPORT_MAX (__IFLA_BRPORT_MAX - 1) -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 11/25/14 05:28, Jiri Pirko wrote: > From: Scott Feldman <sfeldma@gmail.com> > > This policy flag controls syncing of learned FDB entries to bridge's FDB. If > on, FDB entries learned on bridge port device will be synced. If off, device > may still learn new FDB entries but they will not be synced with bridge's FDB. > > Signed-off-by: Scott Feldman <sfeldma@gmail.com> > Signed-off-by: Jiri Pirko <jiri@resnulli.us> Ah - so this is hiding over here. If you introduced this patch first then showed in patch 9 that *it is checked against* for policy, then you can add my ACK for both cheers, jamal -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, Nov 25, 2014 at 11:28:45AM +0100, Jiri Pirko wrote: > From: Scott Feldman <sfeldma@gmail.com> > > This policy flag controls syncing of learned FDB entries to bridge's FDB. If > on, FDB entries learned on bridge port device will be synced. If off, device > may still learn new FDB entries but they will not be synced with bridge's FDB. > > Signed-off-by: Scott Feldman <sfeldma@gmail.com> > Signed-off-by: Jiri Pirko <jiri@resnulli.us> Acked-by: Andy Gospodarek <gospo@cumulusnetworks.com> > --- > new in v3 > --- > include/linux/if_bridge.h | 1 + > include/uapi/linux/if_link.h | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/include/linux/if_bridge.h b/include/linux/if_bridge.h > index b4bb104..67b7a8e 100644 > --- a/include/linux/if_bridge.h > +++ b/include/linux/if_bridge.h > @@ -42,6 +42,7 @@ struct br_ip_list { > #define BR_AUTO_MASK (BR_FLOOD | BR_LEARNING) > #define BR_PROMISC 0x00000080 > #define BR_PROXYARP 0x00000100 > +#define BR_LEARNING_SYNC 0x00000200 > > extern void brioctl_set(int (*ioctl_hook)(struct net *, unsigned int, void __user *)); > > diff --git a/include/uapi/linux/if_link.h b/include/uapi/linux/if_link.h > index 4163753..d8e6a31 100644 > --- a/include/uapi/linux/if_link.h > +++ b/include/uapi/linux/if_link.h > @@ -245,6 +245,7 @@ enum { > IFLA_BRPORT_LEARNING, /* mac learning */ > IFLA_BRPORT_UNICAST_FLOOD, /* flood unicast traffic */ > IFLA_BRPORT_PROXYARP, /* proxy ARP */ > + IFLA_BRPORT_LEARNING_SYNC, /* mac learning sync from device */ > __IFLA_BRPORT_MAX > }; > #define IFLA_BRPORT_MAX (__IFLA_BRPORT_MAX - 1) > -- > 1.9.3 > -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/include/linux/if_bridge.h b/include/linux/if_bridge.h index b4bb104..67b7a8e 100644 --- a/include/linux/if_bridge.h +++ b/include/linux/if_bridge.h @@ -42,6 +42,7 @@ struct br_ip_list { #define BR_AUTO_MASK (BR_FLOOD | BR_LEARNING) #define BR_PROMISC 0x00000080 #define BR_PROXYARP 0x00000100 +#define BR_LEARNING_SYNC 0x00000200 extern void brioctl_set(int (*ioctl_hook)(struct net *, unsigned int, void __user *)); diff --git a/include/uapi/linux/if_link.h b/include/uapi/linux/if_link.h index 4163753..d8e6a31 100644 --- a/include/uapi/linux/if_link.h +++ b/include/uapi/linux/if_link.h @@ -245,6 +245,7 @@ enum { IFLA_BRPORT_LEARNING, /* mac learning */ IFLA_BRPORT_UNICAST_FLOOD, /* flood unicast traffic */ IFLA_BRPORT_PROXYARP, /* proxy ARP */ + IFLA_BRPORT_LEARNING_SYNC, /* mac learning sync from device */ __IFLA_BRPORT_MAX }; #define IFLA_BRPORT_MAX (__IFLA_BRPORT_MAX - 1)