From patchwork Fri Dec 18 15:25:00 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: [2/7] QMP: Return an empty dict by default Date: Fri, 18 Dec 2009 05:25:00 -0000 From: Luiz Capitulino X-Patchwork-Id: 41407 Message-Id: <1261149905-7622-3-git-send-email-lcapitulino@redhat.com> To: qemu-devel@nongnu.org Cc: aliguori@us.ibm.com Currently, when a regular command doesn't have any data to output, QMP will emit: { "return": "OK" } Returning an empty dict is better though, because dicts can support some protocol changes in a compatible way. So, with this commit we will return: { "return": {} } Signed-off-by: Luiz Capitulino --- monitor.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/monitor.c b/monitor.c index 1455258..d238660 100644 --- a/monitor.c +++ b/monitor.c @@ -286,7 +286,8 @@ static void monitor_protocol_emitter(Monitor *mon, QObject *data) qobject_incref(data); qdict_put_obj(qmp, "return", data); } else { - qdict_put(qmp, "return", qstring_from_str("OK")); + /* return an empty QDict by default */ + qdict_put(qmp, "return", qdict_new()); } } else { /* error response */