Patchwork [1/7] QMP: Only handle converted commands

login
register
mail settings
Submitter Luiz Capitulino
Date Dec. 18, 2009, 3:24 p.m.
Message ID <1261149905-7622-2-git-send-email-lcapitulino@redhat.com>
Download mbox | patch
Permalink /patch/41406/
State New
Headers show

Comments

Luiz Capitulino - Dec. 18, 2009, 3:24 p.m.
Looks like I dropped this check when addressing the 'query-'
commands request.

QMP should only handle converted commands, obviously.

Reported-by: Markus Armbruster <armbru@redhat.com>

Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
---
 monitor.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Patch

diff --git a/monitor.c b/monitor.c
index ebd0282..1455258 100644
--- a/monitor.c
+++ b/monitor.c
@@ -4070,7 +4070,7 @@  static void handle_qmp_command(JSONMessageParser *parser, QList *tokens)
                       qobject_from_jsonf("{ 'item': %s }", info_item));
     } else {
         cmd = monitor_find_command(cmd_name);
-        if (!cmd) {
+        if (!cmd || !monitor_handler_ported(cmd)) {
             qemu_error_new(QERR_COMMAND_NOT_FOUND, cmd_name);
             goto err_input;
         }