Patchwork netns: fix net.ipv6.route.gc_min_interval_ms in netns

login
register
mail settings
Submitter Alexey Dobriyan
Date Dec. 18, 2009, 2:16 p.m.
Message ID <b6fcc0a0912180616m54c0d25dn56f008c9d736e505@mail.gmail.com>
Download mbox | patch
Permalink /patch/41403/
State Accepted
Delegated to: David Miller
Headers show

Comments

Alexey Dobriyan - Dec. 18, 2009, 2:16 p.m.
Sorry for attachment, my patch sending facility is defunct right now.
Copying inline for review.

commit ee0270199605e58c76294f62ba8fbc0f583ccd3e
Author: Alexey Dobriyan <adobriyan@gmail.com>
Date:   Fri Dec 18 16:08:04 2009 +0200

    netns: fix net.ipv6.route.gc_min_interval_ms in netns

    sysctl table was copied, all right, but ->data for
net.ipv6.route.gc_min_interval_ms
    was not reinitialized for "!= &init_net" case.

    In init_net everthing works by accident due to correct ->data initialization
    in source table.

    Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
David Miller - Dec. 19, 2009, 4:11 a.m.
From: Alexey Dobriyan <adobriyan@gmail.com>
Date: Fri, 18 Dec 2009 16:16:40 +0200

>     netns: fix net.ipv6.route.gc_min_interval_ms in netns
> 
>     sysctl table was copied, all right, but ->data for
> net.ipv6.route.gc_min_interval_ms
>     was not reinitialized for "!= &init_net" case.
> 
>     In init_net everthing works by accident due to correct ->data initialization
>     in source table.
> 
>     Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>

Applied, thank you.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

commit ee0270199605e58c76294f62ba8fbc0f583ccd3e
Author: Alexey Dobriyan <adobriyan@gmail.com>
Date:   Fri Dec 18 16:08:04 2009 +0200

    netns: fix net.ipv6.route.gc_min_interval_ms in netns
    
    sysctl table was copied, all right, but ->data for net.ipv6.route.gc_min_interval_ms
    was not reinitialized for "!= &init_net" case.
    
    In init_net everthing works by accident due to correct ->data initialization
    in source table.

    Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>

diff --git a/net/ipv6/route.c b/net/ipv6/route.c
index db3b273..c2bd74c 100644
--- a/net/ipv6/route.c
+++ b/net/ipv6/route.c
@@ -2630,6 +2630,7 @@  struct ctl_table *ipv6_route_sysctl_init(struct net *net)
 		table[6].data = &net->ipv6.sysctl.ip6_rt_gc_elasticity;
 		table[7].data = &net->ipv6.sysctl.ip6_rt_mtu_expires;
 		table[8].data = &net->ipv6.sysctl.ip6_rt_min_advmss;
+		table[9].data = &net->ipv6.sysctl.ip6_rt_gc_min_interval;
 	}
 
 	return table;