diff mbox

ext4: remove unneeded code in ext4_unlink

Message ID 003601d007b1$ffde29e0$ff9a7da0$@samsung.com
State Accepted, archived
Headers show

Commit Message

Namjae Jeon Nov. 24, 2014, 6:43 a.m. UTC 
Setting retval to zero is not needed in ext4_unlink.
Remove unneeded code.

Signed-off-by: Namjae Jeon <namjae.jeon@samsung.com>
Signed-off-by: Ashish Sangwan <a.sangwan@samsung.com>
---
 fs/ext4/namei.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Theodore Ts'o Nov. 25, 2014, 9:47 p.m. UTC | #1 
On Mon, Nov 24, 2014 at 03:43:47PM +0900, Namjae Jeon wrote:
> Setting retval to zero is not needed in ext4_unlink.
> Remove unneeded code.
> 
> Signed-off-by: Namjae Jeon <namjae.jeon@samsung.com>
> Signed-off-by: Ashish Sangwan <a.sangwan@samsung.com>

Thanks, applied.

				- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/fs/ext4/namei.c b/fs/ext4/namei.c
index 4262118..2291923 100644
--- a/fs/ext4/namei.c
+++ b/fs/ext4/namei.c
@@ -2814,7 +2814,6 @@  static int ext4_unlink(struct inode *dir, struct dentry *dentry)
 		ext4_orphan_add(handle, inode);
 	inode->i_ctime = ext4_current_time(inode);
 	ext4_mark_inode_dirty(handle, inode);
-	retval = 0;
 
 end_unlink:
 	brelse(bh);