diff mbox

[1/1] package/nfs-utils: Fix static build

Message ID 1416748839-5316-1-git-send-email-bernd.kuhls@t-online.de
State Superseded
Headers show

Commit Message

Bernd Kuhls Nov. 23, 2014, 1:20 p.m. UTC
Fixes
http://autobuild.buildroot.net/results/17d/17d1d94e6f1617851e374f4fe9804f1e5ea9e99f/
http://autobuild.buildroot.net/results/c08/c08b7be40c8f208147a4f95ad897e4a1df7e108d/

Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
---
 package/nfs-utils/nfs-utils.mk |    3 +++
 1 file changed, 3 insertions(+)

Comments

Bernd Kuhls Nov. 23, 2014, 1:26 p.m. UTC | #1
Bernd Kuhls <bernd.kuhls@t-online.de> wrote in 
news:1416748839-5316-1-git-send-email-bernd.kuhls@t-online.de:

> +ifeq ($(BR2_PREFER_STATIC_LIB),y)
> +NFS_UTILS_CONF_ENV += LIBS="-lpthread"
> +endif

Hi,

lol, Yann and I had the same thought, but his patch is better, therefore I 
marked mine as superseded in patchworks ;)

Regards, Bernd
Yann E. MORIN Nov. 23, 2014, 1:33 p.m. UTC | #2
Bernd, All!

On 2014-11-23 14:26 +0100, Bernd Kuhls spake thusly:
> Bernd Kuhls <bernd.kuhls@t-online.de> wrote in 
> news:1416748839-5316-1-git-send-email-bernd.kuhls@t-online.de:
> > +ifeq ($(BR2_PREFER_STATIC_LIB),y)
> > +NFS_UTILS_CONF_ENV += LIBS="-lpthread"
> > +endif
> 
> lol,

Indeed! That's pretty funny! :-)

> Yann and I had the same thought, but his patch is better, therefore I 
> marked mine as superseded in patchworks ;)

However, your patch is much simpler, and might be considered sufficient
for the release.

So I would not have been so prompt as to mark it in Patchwork.

Peter, Thomas, what's your preference?

Regards,
Yann E. MORIN.
diff mbox

Patch

diff --git a/package/nfs-utils/nfs-utils.mk b/package/nfs-utils/nfs-utils.mk
index 522e790..4049024 100644
--- a/package/nfs-utils/nfs-utils.mk
+++ b/package/nfs-utils/nfs-utils.mk
@@ -29,6 +29,9 @@  NFS_UTILS_TARGETS_$(BR2_PACKAGE_NFS_UTILS_RPC_RQUOTAD) += usr/sbin/rpc.rquotad
 
 ifeq ($(BR2_PACKAGE_LIBTIRPC),y)
 NFS_UTILS_CONF_OPTS += --enable-tirpc --with-tirpcinclude=$(STAGING_DIR)/usr/include/tirpc/
+ifeq ($(BR2_PREFER_STATIC_LIB),y)
+NFS_UTILS_CONF_ENV += LIBS="-lpthread"
+endif
 NFS_UTILS_DEPENDENCIES += libtirpc
 else
 NFS_UTILS_CONF_OPTS += --disable-tirpc