Message ID | 1416499328-13083-1-git-send-email-damien@kal-host.com |
---|---|
State | Accepted |
Headers | show |
Dear Damien Lanson, Thanks for your contribution! On Thu, 20 Nov 2014 17:02:08 +0100, Damien Lanson wrote: > New try to send a patch with git send-email. This patch remove building and > installing sample for xerces. If it's good, I have other patch to remove > building and/or installing of sample or example or dev file in some package. Unfortunately, this is not good yet to be applied. When you do a "git format-patch", you should send the patch unchanged with "git send-email". Or if you want to make some comments, do them below the "---" sign. Right now, from the point of view of git, the description of your patch is the personal message "New try to send a patch ...". Basically, your process to send the patch should be: git format-patch HEAD^ git send-email 0001-....patch Also, while your patch certainly works, it would be good to have a solution that can potentially be submitted upstream, by patching configure.ac to provide a --enable-samples/--disable-samples option. It's also a good idea to add a small commit log to explain why this commit is needed. And finally, the title of your commit should be: xerces: disable the build of samples i.e, it should always have "<pkg>: " as a prefix. Can you resend an updated version of your patch with those changes? Thanks a lot! Thomas
Dear Damien Lanson, On Thu, 20 Nov 2014 17:02:08 +0100, Damien Lanson wrote: > New try to send a patch with git send-email. This patch remove building and > installing sample for xerces. If it's good, I have other patch to remove > building and/or installing of sample or example or dev file in some package. Thanks, applied after tweaking the commit log, and rebased on master. Thomas
diff --git a/package/xerces/xerces.mk b/package/xerces/xerces.mk index 36955e3..1beaf21 100644 --- a/package/xerces/xerces.mk +++ b/package/xerces/xerces.mk @@ -11,6 +11,13 @@ XERCES_LICENSE = Apache-2.0 XERCES_LICENSE_FILES = LICENSE XERCES_MAKE = $(MAKE1) XERCES_INSTALL_STAGING = YES + +define XERCES_DISABLE_SAMPLES + $(SED) 's/ samples//' $(@D)/Makefile.in +endef + +XERCES_POST_PATCH_HOOKS += XERCES_DISABLE_SAMPLES + XERCES_CONF_OPTS = --disable-threads \ --with-gnu-ld