Patchwork [1/5] powerpc/iseries: use DECLARE_COMPLETION_ONSTACK for non-constant completion

login
register
mail settings
Submitter Yong Zhang
Date Dec. 16, 2009, 2:35 p.m.
Message ID <1260974161-6934-2-git-send-email-yong.zhang0@gmail.com>
Download mbox | patch
Permalink /patch/41270/
State Accepted
Commit c3a66359398028cd8e5f32611950dc7dc32ea2f2
Delegated to: Benjamin Herrenschmidt
Headers show

Comments

Yong Zhang - Dec. 16, 2009, 2:35 p.m.
The _ONSTACK variant should be used for on-stack completion,
otherwise it will break lockdep.

Signed-off-by: Yong Zhang <yong.zhang0@gmail.com>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Paul Mackerras <paulus@samba.org>
Cc: linuxppc-dev@ozlabs.org
---
 arch/powerpc/platforms/iseries/viopath.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Patch

diff --git a/arch/powerpc/platforms/iseries/viopath.c b/arch/powerpc/platforms/iseries/viopath.c
index 49ff4dc..5aea94f 100644
--- a/arch/powerpc/platforms/iseries/viopath.c
+++ b/arch/powerpc/platforms/iseries/viopath.c
@@ -116,7 +116,7 @@  static int proc_viopath_show(struct seq_file *m, void *v)
 	u16 vlanMap;
 	dma_addr_t handle;
 	HvLpEvent_Rc hvrc;
-	DECLARE_COMPLETION(done);
+	DECLARE_COMPLETION_ONSTACK(done);
 	struct device_node *node;
 	const char *sysid;