Patchwork [Karmic] SRU: Disable CONFIG_USB_DEVICEFS

login
register
mail settings
Submitter Stefan Bader
Date Dec. 16, 2009, 11 a.m.
Message ID <1260961244-5946-1-git-send-email-stefan.bader@canonical.com>
Download mbox | patch
Permalink /patch/41246/
State Accepted
Delegated to: Stefan Bader
Headers show

Comments

Stefan Bader - Dec. 16, 2009, 11 a.m.
SRU Justification:

Impact: We were talked into enable that for Karmic by users with
broken applications without realizing the side-effect of breaking
udev (as it implicitely changes event behavior).

Fix: Revert back to not have this option enabled. It is deprecated
anyways and applications need to be fixed sooner than later.

-Stefan

From 8214b4a6265c27289e7c4166357a95faeb1ed7aa Mon Sep 17 00:00:00 2001
From: Stefan Bader <stefan.bader@canonical.com>
Date: Wed, 16 Dec 2009 11:50:53 +0100
Subject: [PATCH] UBUNTU: [Config] Disable CONFIG_USB_DEVICEFS

BugLink: http://bugs.launchpad.net/bugs/488274

This option is incompatible with the udev in karmic and lucid, leading
to failure to load firmware files for various pieces of USB kit. It is
also now deprecated and going away very shortly. We should therefore
re-disable it. More details are in the thread below:

    http://markmail.org/message/3mw5yw465qmxgnwp

Although older versions of Virtualbox and VMWare needed it we do not
believe that current versions use it.

This reverts the change done requested for Karmic by the following
bug report:

    https://bugs.launchpad.net/bugs/417748

Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
---
 debian.master/config/config.common.ubuntu |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Andy Whitcroft - Dec. 16, 2009, 12:15 p.m.
On Wed, Dec 16, 2009 at 12:00:44PM +0100, Stefan Bader wrote:
> SRU Justification:
> 
> Impact: We were talked into enable that for Karmic by users with
> broken applications without realizing the side-effect of breaking
> udev (as it implicitely changes event behavior).

Impact: With this option enabled firmware for USB connected devices may
fail to load regressing functionality for these devices.  The option
was only enabled to fix already broken applications which use this long
deprecated filesystem; they probabaly should be directed to Hardy instead.

> Fix: Revert back to not have this option enabled. It is deprecated
> anyways and applications need to be fixed sooner than later.
> 
> -Stefan
> 
> From 8214b4a6265c27289e7c4166357a95faeb1ed7aa Mon Sep 17 00:00:00 2001
> From: Stefan Bader <stefan.bader@canonical.com>
> Date: Wed, 16 Dec 2009 11:50:53 +0100
> Subject: [PATCH] UBUNTU: [Config] Disable CONFIG_USB_DEVICEFS
> 
> BugLink: http://bugs.launchpad.net/bugs/488274
> 
> This option is incompatible with the udev in karmic and lucid, leading
> to failure to load firmware files for various pieces of USB kit. It is
> also now deprecated and going away very shortly. We should therefore
> re-disable it. More details are in the thread below:
> 
>     http://markmail.org/message/3mw5yw465qmxgnwp
> 
> Although older versions of Virtualbox and VMWare needed it we do not
> believe that current versions use it.
> 
> This reverts the change done requested for Karmic by the following
> bug report:
> 
>     https://bugs.launchpad.net/bugs/417748
> 
> Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
> ---
>  debian.master/config/config.common.ubuntu |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/debian.master/config/config.common.ubuntu b/debian.master/config/config.common.ubuntu
> index c6bbae9..462c1c1 100644
> --- a/debian.master/config/config.common.ubuntu
> +++ b/debian.master/config/config.common.ubuntu
> @@ -3783,7 +3783,7 @@ CONFIG_USB_CYPRESS_CY7C63=m
>  CONFIG_USB_CYTHERM=m
>  CONFIG_USB_DABUSB=m
>  # CONFIG_USB_DEBUG is not set
> -CONFIG_USB_DEVICEFS=y
> +# CONFIG_USB_DEVICEFS is not set
>  # CONFIG_USB_DEVICE_CLASS is not set
>  CONFIG_USB_DSBR=m
>  CONFIG_USB_DUMMY_HCD=m

Acked-by: Andy Whitcroft <apw@canonical.com>

-apw
Tim Gardner - Dec. 22, 2009, 2:29 a.m.
Stefan Bader wrote:
> SRU Justification:
> 
> Impact: We were talked into enable that for Karmic by users with
> broken applications without realizing the side-effect of breaking
> udev (as it implicitely changes event behavior).
> 
> Fix: Revert back to not have this option enabled. It is deprecated
> anyways and applications need to be fixed sooner than later.
> 
> -Stefan
> 
> From 8214b4a6265c27289e7c4166357a95faeb1ed7aa Mon Sep 17 00:00:00 2001
> From: Stefan Bader <stefan.bader@canonical.com>
> Date: Wed, 16 Dec 2009 11:50:53 +0100
> Subject: [PATCH] UBUNTU: [Config] Disable CONFIG_USB_DEVICEFS
> 
> BugLink: http://bugs.launchpad.net/bugs/488274
> 
> This option is incompatible with the udev in karmic and lucid, leading
> to failure to load firmware files for various pieces of USB kit. It is
> also now deprecated and going away very shortly. We should therefore
> re-disable it. More details are in the thread below:
> 
>     http://markmail.org/message/3mw5yw465qmxgnwp
> 
> Although older versions of Virtualbox and VMWare needed it we do not
> believe that current versions use it.
> 
> This reverts the change done requested for Karmic by the following
> bug report:
> 
>     https://bugs.launchpad.net/bugs/417748
> 
> Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
> ---
>  debian.master/config/config.common.ubuntu |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/debian.master/config/config.common.ubuntu b/debian.master/config/config.common.ubuntu
> index c6bbae9..462c1c1 100644
> --- a/debian.master/config/config.common.ubuntu
> +++ b/debian.master/config/config.common.ubuntu
> @@ -3783,7 +3783,7 @@ CONFIG_USB_CYPRESS_CY7C63=m
>  CONFIG_USB_CYTHERM=m
>  CONFIG_USB_DABUSB=m
>  # CONFIG_USB_DEBUG is not set
> -CONFIG_USB_DEVICEFS=y
> +# CONFIG_USB_DEVICEFS is not set
>  # CONFIG_USB_DEVICE_CLASS is not set
>  CONFIG_USB_DSBR=m
>  CONFIG_USB_DUMMY_HCD=m

ACK
Stefan Bader - Dec. 22, 2009, 12:58 p.m.
Applied and pushed to Karmic
Jerone Young - Feb. 16, 2010, 2:35 p.m.
This is more like pulling the rug from under users.  Some
applications .. such as virtual box, use this currently (even though
they should not) to properly grab usb devices.

Changes like this should be best left for Lucid so users don't get a
surprise when they update their kernel.


				Jerone
On Wed, 2009-12-16 at 12:15 +0000, Andy Whitcroft wrote:
> l to load regressing functionality for these devices.  The option
> was only enabled to fix already broken applications which use this
> long
> deprecated filesystem; they probabaly should be directed to Hardy
> instead.
> 
> > Fix: Revert back to not have this option enabled. It is deprecated
> > anyways and applications need to be fixed sooner than later.
Andy Whitcroft - April 8, 2010, 3:40 p.m.
On Tue, Feb 16, 2010 at 08:35:59AM -0600, Jerone Young wrote:
> This is more like pulling the rug from under users.  Some
> applications .. such as virtual box, use this currently (even though
> they should not) to properly grab usb devices.
> 
> Changes like this should be best left for Lucid so users don't get a
> surprise when they update their kernel.

Missed this ... but ...

The change was only introduced mid-karmic, and we later found that you
cannot enable it and have general USB device firmware loading.  It is
and has been deprecated for so very long that noone should be using it.
It is incompatible with other things in Karmic and should not have been
enabled.

-apw

Patch

diff --git a/debian.master/config/config.common.ubuntu b/debian.master/config/config.common.ubuntu
index c6bbae9..462c1c1 100644
--- a/debian.master/config/config.common.ubuntu
+++ b/debian.master/config/config.common.ubuntu
@@ -3783,7 +3783,7 @@  CONFIG_USB_CYPRESS_CY7C63=m
 CONFIG_USB_CYTHERM=m
 CONFIG_USB_DABUSB=m
 # CONFIG_USB_DEBUG is not set
-CONFIG_USB_DEVICEFS=y
+# CONFIG_USB_DEVICEFS is not set
 # CONFIG_USB_DEVICE_CLASS is not set
 CONFIG_USB_DSBR=m
 CONFIG_USB_DUMMY_HCD=m