Patchwork [V2,09/10] piix_pci: use range helper function

login
register
mail settings
Submitter Isaku Yamahata
Date Dec. 15, 2009, 11:26 a.m.
Message ID <1260876367-28197-10-git-send-email-yamahata@valinux.co.jp>
Download mbox | patch
Permalink /patch/41180/
State New
Headers show

Comments

Isaku Yamahata - Dec. 15, 2009, 11:26 a.m.
use range helper function in i440fx_write_config().

Signed-off-by: Isaku Yamahata <yamahata@valinux.co.jp>
---
 hw/piix_pci.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

Patch

diff --git a/hw/piix_pci.c b/hw/piix_pci.c
index 0dae6f9..384d31c 100644
--- a/hw/piix_pci.c
+++ b/hw/piix_pci.c
@@ -137,10 +137,10 @@  static void i440fx_write_config(PCIDevice *dev,
 
     /* XXX: implement SMRAM.D_LOCK */
     pci_default_write_config(dev, address, val, len);
-    if ((address >= I440FX_PAM &&
-         address <= I440FX_PAM + I440FX_PAM_SIZE - 1) ||
-        address == I440FX_SMRAM)
+    if (ranges_overlap(address, len, I440FX_PAM, I440FX_PAM_SIZE) ||
+        range_covers_byte(address, len, I440FX_SMRAM)) {
         i440fx_update_memory_mappings(d);
+    }
 }
 
 static int i440fx_load_old(QEMUFile* f, void *opaque, int version_id)