| Message ID | 1416235920-16184-2-git-send-email-ben.dooks@codethink.co.uk |
|---|---|
| State | Accepted |
| Delegated to: | Jagannadha Sutradharudu Teki |
| Headers | show |
On 17 November 2014 at 20:21, Ben Dooks <ben.dooks@codethink.co.uk> wrote: > From: Adnan Ali <adnan.ali@codethink.co.uk> > > Add S25FL064A and S25FL116K flash indentifiers. > > Signed-off-by: Adnan Ali <adnan.ali@codethink.co.uk> > --- > drivers/mtd/spi/sf_params.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/mtd/spi/sf_params.c b/drivers/mtd/spi/sf_params.c > index 61545ca..462e5c2 100644 > --- a/drivers/mtd/spi/sf_params.c > +++ b/drivers/mtd/spi/sf_params.c > @@ -51,6 +51,8 @@ const struct spi_flash_params spi_flash_params_table[] = { > {"S25FL016A", 0x010214, 0x0, 64 * 1024, 32, 0, 0}, > {"S25FL032A", 0x010215, 0x0, 64 * 1024, 64, 0, 0}, > {"S25FL064A", 0x010216, 0x0, 64 * 1024, 128, 0, 0}, > + {"S25FL064A", 0x010216, 0x0, 64 * 1024, 128, 0, 0}, What is this, already there the same part - any new? > + {"S25FL116k", 0x014015, 0x0, 64 * 1024, 128, 0, 0}, Is this tested! can you rebase master and send the same patches. > {"S25FL128P_256K", 0x012018, 0x0300, 256 * 1024, 64, RD_FULL, WR_QPP}, > {"S25FL128P_64K", 0x012018, 0x0301, 64 * 1024, 256, RD_FULL, WR_QPP}, > {"S25FL032P", 0x010215, 0x4d00, 64 * 1024, 64, RD_FULL, WR_QPP}, > -- > 2.1.1 > thanks!
On 18/12/14 12:14, Jagan Teki wrote: > On 17 November 2014 at 20:21, Ben Dooks <ben.dooks@codethink.co.uk> wrote: >> From: Adnan Ali <adnan.ali@codethink.co.uk> >> >> Add S25FL064A and S25FL116K flash indentifiers. >> >> Signed-off-by: Adnan Ali <adnan.ali@codethink.co.uk> >> --- >> drivers/mtd/spi/sf_params.c | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/drivers/mtd/spi/sf_params.c b/drivers/mtd/spi/sf_params.c >> index 61545ca..462e5c2 100644 >> --- a/drivers/mtd/spi/sf_params.c >> +++ b/drivers/mtd/spi/sf_params.c >> @@ -51,6 +51,8 @@ const struct spi_flash_params spi_flash_params_table[] = { >> {"S25FL016A", 0x010214, 0x0, 64 * 1024, 32, 0, 0}, >> {"S25FL032A", 0x010215, 0x0, 64 * 1024, 64, 0, 0}, >> {"S25FL064A", 0x010216, 0x0, 64 * 1024, 128, 0, 0}, >> + {"S25FL064A", 0x010216, 0x0, 64 * 1024, 128, 0, 0}, > > What is this, already there the same part - any new? I must have missed this when re-basing off the previous u-boot. >> + {"S25FL116k", 0x014015, 0x0, 64 * 1024, 128, 0, 0}, > > Is this tested! can you rebase master and send the same patches. Yes, it was one of the devices we looked at and tested on a Marvell 88F6281 based system. >> {"S25FL128P_256K", 0x012018, 0x0300, 256 * 1024, 64, RD_FULL, WR_QPP}, >> {"S25FL128P_64K", 0x012018, 0x0301, 64 * 1024, 256, RD_FULL, WR_QPP}, >> {"S25FL032P", 0x010215, 0x4d00, 64 * 1024, 64, RD_FULL, WR_QPP}, >> -- >> 2.1.1 >> > > thanks! >
On 18 December 2014 at 18:38, Ben Dooks <ben.dooks@codethink.co.uk> wrote: > On 18/12/14 12:14, Jagan Teki wrote: >> On 17 November 2014 at 20:21, Ben Dooks <ben.dooks@codethink.co.uk> wrote: >>> From: Adnan Ali <adnan.ali@codethink.co.uk> >>> >>> Add S25FL064A and S25FL116K flash indentifiers. >>> >>> Signed-off-by: Adnan Ali <adnan.ali@codethink.co.uk> >>> --- >>> drivers/mtd/spi/sf_params.c | 2 ++ >>> 1 file changed, 2 insertions(+) >>> >>> diff --git a/drivers/mtd/spi/sf_params.c b/drivers/mtd/spi/sf_params.c >>> index 61545ca..462e5c2 100644 >>> --- a/drivers/mtd/spi/sf_params.c >>> +++ b/drivers/mtd/spi/sf_params.c >>> @@ -51,6 +51,8 @@ const struct spi_flash_params spi_flash_params_table[] = { >>> {"S25FL016A", 0x010214, 0x0, 64 * 1024, 32, 0, 0}, >>> {"S25FL032A", 0x010215, 0x0, 64 * 1024, 64, 0, 0}, >>> {"S25FL064A", 0x010216, 0x0, 64 * 1024, 128, 0, 0}, >>> + {"S25FL064A", 0x010216, 0x0, 64 * 1024, 128, 0, 0}, >> >> What is this, already there the same part - any new? > > I must have missed this when re-basing off the previous u-boot. > >>> + {"S25FL116k", 0x014015, 0x0, 64 * 1024, 128, 0, 0}, >> >> Is this tested! can you rebase master and send the same patches. > > Yes, it was one of the devices we looked at and tested on a Marvell > 88F6281 based system. > >>> {"S25FL128P_256K", 0x012018, 0x0300, 256 * 1024, 64, RD_FULL, WR_QPP}, >>> {"S25FL128P_64K", 0x012018, 0x0301, 64 * 1024, 256, RD_FULL, WR_QPP}, >>> {"S25FL032P", 0x010215, 0x4d00, 64 * 1024, 64, RD_FULL, WR_QPP}, >>> -- >>> 2.1.1 >>> Applied to u-boot-spi/master thanks!
diff --git a/drivers/mtd/spi/sf_params.c b/drivers/mtd/spi/sf_params.c index 61545ca..462e5c2 100644 --- a/drivers/mtd/spi/sf_params.c +++ b/drivers/mtd/spi/sf_params.c @@ -51,6 +51,8 @@ const struct spi_flash_params spi_flash_params_table[] = { {"S25FL016A", 0x010214, 0x0, 64 * 1024, 32, 0, 0}, {"S25FL032A", 0x010215, 0x0, 64 * 1024, 64, 0, 0}, {"S25FL064A", 0x010216, 0x0, 64 * 1024, 128, 0, 0}, + {"S25FL064A", 0x010216, 0x0, 64 * 1024, 128, 0, 0}, + {"S25FL116k", 0x014015, 0x0, 64 * 1024, 128, 0, 0}, {"S25FL128P_256K", 0x012018, 0x0300, 256 * 1024, 64, RD_FULL, WR_QPP}, {"S25FL128P_64K", 0x012018, 0x0301, 64 * 1024, 256, RD_FULL, WR_QPP}, {"S25FL032P", 0x010215, 0x4d00, 64 * 1024, 64, RD_FULL, WR_QPP},