| Message ID | 546A0AC1.9060909@arm.com |
|---|---|
| State | New |
| Headers | show |
On Mon, Nov 17, 2014 at 2:48 PM, Kyrill Tkachov <kyrylo.tkachov@arm.com> wrote: > Hi all, > > Some configurations of Cortex-A53 and Cortex-A57 don't ship with crypto, > so enabling it by default for -mcpu=cortex-a53 and cortex-a57 is > inappropriate. > > Tested aarch64-none-elf. Reminder that at the moment all the crypto > extension does is enable the use of the ACLE crypto intrinsics in arm_neon.h > > Ok for trunk? I can't ok this but ... Since we've changed behaviour from 4.9 I think it warrants an entry in changes.html for 5.0 Ramana > > Thanks, > Kyrill > > 2014-11-17 Kyrylo Tkachov <kyrylo.tkachov@arm.com> > > * config/aarch64/aarch64-cores.def (cortex-a53): Remove > AARCH64_FL_CRYPTO from feature flags. > (cortex-a57): Likewise. > (cortex-a57.cortex-a53): Likewise.
> On Nov 17, 2014, at 8:59 AM, Ramana Radhakrishnan <ramana.gcc@googlemail.com> wrote: > >> On Mon, Nov 17, 2014 at 2:48 PM, Kyrill Tkachov <kyrylo.tkachov@arm.com> wrote: >> Hi all, >> >> Some configurations of Cortex-A53 and Cortex-A57 don't ship with crypto, >> so enabling it by default for -mcpu=cortex-a53 and cortex-a57 is >> inappropriate. >> >> Tested aarch64-none-elf. Reminder that at the moment all the crypto >> extension does is enable the use of the ACLE crypto intrinsics in arm_neon.h >> >> Ok for trunk? > > I can't ok this but ... > > Since we've changed behaviour from 4.9 I think it warrants an entry in > changes.html for 5.0 ThunderX should also disable crypto too by default. I will submit a patch for that soon too. Thanks, Andrew > > Ramana > >> >> Thanks, >> Kyrill >> >> 2014-11-17 Kyrylo Tkachov <kyrylo.tkachov@arm.com> >> >> * config/aarch64/aarch64-cores.def (cortex-a53): Remove >> AARCH64_FL_CRYPTO from feature flags. >> (cortex-a57): Likewise. >> (cortex-a57.cortex-a53): Likewise.
On 17 November 2014 14:48, Kyrill Tkachov <kyrylo.tkachov@arm.com> wrote: > Hi all, > > Some configurations of Cortex-A53 and Cortex-A57 don't ship with crypto, > so enabling it by default for -mcpu=cortex-a53 and cortex-a57 is > inappropriate. > > Tested aarch64-none-elf. Reminder that at the moment all the crypto > extension does is enable the use of the ACLE crypto intrinsics in arm_neon.h > > Ok for trunk? > > Thanks, > Kyrill > > 2014-11-17 Kyrylo Tkachov <kyrylo.tkachov@arm.com> > > * config/aarch64/aarch64-cores.def (cortex-a53): Remove > AARCH64_FL_CRYPTO from feature flags. > (cortex-a57): Likewise. > (cortex-a57.cortex-a53): Likewise. OK and please propose the changes.html patch Ramana suggested. /Marcus
On 17/11/14 17:03, pinskia@gmail.com wrote: > > > > >> On Nov 17, 2014, at 8:59 AM, Ramana Radhakrishnan <ramana.gcc@googlemail.com> wrote: >> >>> On Mon, Nov 17, 2014 at 2:48 PM, Kyrill Tkachov <kyrylo.tkachov@arm.com> wrote: >>> Hi all, >>> >>> Some configurations of Cortex-A53 and Cortex-A57 don't ship with crypto, >>> so enabling it by default for -mcpu=cortex-a53 and cortex-a57 is >>> inappropriate. >>> >>> Tested aarch64-none-elf. Reminder that at the moment all the crypto >>> extension does is enable the use of the ACLE crypto intrinsics in arm_neon.h >>> >>> Ok for trunk? >> >> I can't ok this but ... >> >> Since we've changed behaviour from 4.9 I think it warrants an entry in >> changes.html for 5.0 > > ThunderX should also disable crypto too by default. I will submit a patch for that soon too. > You appear to have not yet done so... BTW, you can consider such a change pre-approved. R. > Thanks, > Andrew > >> >> Ramana >> >>> >>> Thanks, >>> Kyrill >>> >>> 2014-11-17 Kyrylo Tkachov <kyrylo.tkachov@arm.com> >>> >>> * config/aarch64/aarch64-cores.def (cortex-a53): Remove >>> AARCH64_FL_CRYPTO from feature flags. >>> (cortex-a57): Likewise. >>> (cortex-a57.cortex-a53): Likewise. >
diff --git a/gcc/config/aarch64/aarch64-cores.def b/gcc/config/aarch64/aarch64-cores.def index 471cdd6..312941f 100644 --- a/gcc/config/aarch64/aarch64-cores.def +++ b/gcc/config/aarch64/aarch64-cores.def @@ -34,10 +34,10 @@ /* V8 Architecture Processors. */ -AARCH64_CORE("cortex-a53", cortexa53, cortexa53, 8, AARCH64_FL_FPSIMD | AARCH64_FL_CRC | AARCH64_FL_CRYPTO, cortexa53) -AARCH64_CORE("cortex-a57", cortexa15, cortexa15, 8, AARCH64_FL_FPSIMD | AARCH64_FL_CRC | AARCH64_FL_CRYPTO, cortexa57) +AARCH64_CORE("cortex-a53", cortexa53, cortexa53, 8, AARCH64_FL_FPSIMD | AARCH64_FL_CRC, cortexa53) +AARCH64_CORE("cortex-a57", cortexa15, cortexa15, 8, AARCH64_FL_FPSIMD | AARCH64_FL_CRC, cortexa57) AARCH64_CORE("thunderx", thunderx, thunderx, 8, AARCH64_FL_FPSIMD | AARCH64_FL_CRC | AARCH64_FL_CRYPTO, thunderx) /* V8 big.LITTLE implementations. */ -AARCH64_CORE("cortex-a57.cortex-a53", cortexa57cortexa53, cortexa53, 8, AARCH64_FL_FPSIMD | AARCH64_FL_CRC | AARCH64_FL_CRYPTO, cortexa57) +AARCH64_CORE("cortex-a57.cortex-a53", cortexa57cortexa53, cortexa53, 8, AARCH64_FL_FPSIMD | AARCH64_FL_CRC, cortexa57)
Hi all, Some configurations of Cortex-A53 and Cortex-A57 don't ship with crypto, so enabling it by default for -mcpu=cortex-a53 and cortex-a57 is inappropriate. Tested aarch64-none-elf. Reminder that at the moment all the crypto extension does is enable the use of the ACLE crypto intrinsics in arm_neon.h Ok for trunk? Thanks, Kyrill 2014-11-17 Kyrylo Tkachov <kyrylo.tkachov@arm.com> * config/aarch64/aarch64-cores.def (cortex-a53): Remove AARCH64_FL_CRYPTO from feature flags. (cortex-a57): Likewise. (cortex-a57.cortex-a53): Likewise.