| Message ID | 1416224086-5698-2-git-send-email-hdegoede@redhat.com |
|---|---|
| State | Accepted, archived |
| Commit | 5d85a8478ec8a1956f08ad72d1601a3c5cb60b1e |
| Headers | show |
On Mon, Nov 17, 2014 at 11:34 AM, Hans de Goede <hdegoede@redhat.com> wrote: > This goes contrary to how devicetree usually works, so drop it. Instead if > the firmware needs to be able to find a specific node it should use a > platform specific compatible + properties for this. > > Signed-off-by: Hans de Goede <hdegoede@redhat.com> Acked-by: Grant Likely <grant.likely@linaro.org> > --- > Documentation/devicetree/bindings/video/simple-framebuffer.txt | 10 ++++------ > 1 file changed, 4 insertions(+), 6 deletions(-) > > diff --git a/Documentation/devicetree/bindings/video/simple-framebuffer.txt b/Documentation/devicetree/bindings/video/simple-framebuffer.txt > index f8fb7e6..4474ef6 100644 > --- a/Documentation/devicetree/bindings/video/simple-framebuffer.txt > +++ b/Documentation/devicetree/bindings/video/simple-framebuffer.txt > @@ -31,12 +31,10 @@ enable them. This way if e.g. later on support for more display clocks get > added, the simplefb nodes will already contain this info and the firmware > does not need to be updated. > > -If pre-filled framebuffer nodes are used, they should be named > -"framebuffer#-<output>", e.g. "framebuffer0-hdmi". The output should be > -included in the name since different outputs typically require different > -clocks and the clocks are part of the pre-populated nodes. The firmware must > -rename the nodes to the standard "framebuffer@<address>" name using the > -runtime chosen address when enabling the nodes. > +If pre-filled framebuffer nodes are used, the firmware may need extra > +information to find the right node. In that case an extra platform specific > +compatible and platform specific properties should be used and documented, > +see e.g. simple-framebuffer-sunxi.txt . > > Required properties: > - compatible: "simple-framebuffer" > -- > 2.1.0 > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/Documentation/devicetree/bindings/video/simple-framebuffer.txt b/Documentation/devicetree/bindings/video/simple-framebuffer.txt index f8fb7e6..4474ef6 100644 --- a/Documentation/devicetree/bindings/video/simple-framebuffer.txt +++ b/Documentation/devicetree/bindings/video/simple-framebuffer.txt @@ -31,12 +31,10 @@ enable them. This way if e.g. later on support for more display clocks get added, the simplefb nodes will already contain this info and the firmware does not need to be updated. -If pre-filled framebuffer nodes are used, they should be named -"framebuffer#-<output>", e.g. "framebuffer0-hdmi". The output should be -included in the name since different outputs typically require different -clocks and the clocks are part of the pre-populated nodes. The firmware must -rename the nodes to the standard "framebuffer@<address>" name using the -runtime chosen address when enabling the nodes. +If pre-filled framebuffer nodes are used, the firmware may need extra +information to find the right node. In that case an extra platform specific +compatible and platform specific properties should be used and documented, +see e.g. simple-framebuffer-sunxi.txt . Required properties: - compatible: "simple-framebuffer"
This goes contrary to how devicetree usually works, so drop it. Instead if the firmware needs to be able to find a specific node it should use a platform specific compatible + properties for this. Signed-off-by: Hans de Goede <hdegoede@redhat.com> --- Documentation/devicetree/bindings/video/simple-framebuffer.txt | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-)