Patchwork [PATCH:] Fix a make -j race

login
register
mail settings
Submitter Juergen Lock
Date Dec. 14, 2009, 8:54 p.m.
Message ID <20091214205443.GA24776@triton8.kn-bremen.de>
Download mbox | patch
Permalink /patch/41156/
State New
Headers show

Comments

Juergen Lock - Dec. 14, 2009, 8:54 p.m.
Make libuser.a depend on $(GENERATED_HEADERS) too so make -j won't start
building it before the headers exist.  (There may be more bugs like this
but at least this makes (g)make -j4 started from scratch on a quadcore
now always complete here again.)

Signed-off-by: Juergen Lock <nox@jelal.kn-bremen.de>

Patch

--- a/Makefile
+++ b/Makefile
@@ -79,7 +79,7 @@  $(filter %-softmmu,$(SUBDIR_RULES)): lib
 
 $(filter %-user,$(SUBDIR_RULES)): libuser.a
 
-libuser.a:
+libuser.a: $(GENERATED_HEADERS)
 	$(call quiet-command,$(MAKE) $(SUBDIR_MAKEFLAGS) -C libuser V="$(V)" TARGET_DIR="libuser/" all,)
 
 ROMSUBDIR_RULES=$(patsubst %,romsubdir-%, $(ROMS))