Patchwork [4/4] mISDN: misc timerdev fixes

login
register
mail settings
Submitter Andrew Morton
Date Oct. 13, 2008, 2:11 a.m.
Message ID <20081012191113.4aa0d6ef.akpm@linux-foundation.org>
Download mbox | patch
Permalink /patch/4115/
State Superseded
Delegated to: David Miller
Headers show

Comments

Andrew Morton - Oct. 13, 2008, 2:11 a.m.
> On Sun, 12 Oct 2008 07:05:10 -0400 Christoph Hellwig <hch@infradead.org> wrote:
> 
> The bogus version which removes ->llseek just got into Linus' tree..

Well I still have this queued:

From: Andrew Morton <akpm@linux-foundation.org>

Cc: Andi Kleen <andi@firstfloor.org>
Cc: Karsten Keil <kkeil@suse.de>
Cc: Christoph Hellwig <hch@lst.de>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 drivers/isdn/mISDN/timerdev.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Christoph Hellwig - Oct. 13, 2008, 2:16 a.m.
On Sun, Oct 12, 2008 at 07:11:13PM -0700, Andrew Morton wrote:
> > On Sun, 12 Oct 2008 07:05:10 -0400 Christoph Hellwig <hch@infradead.org> wrote:
> > 
> > The bogus version which removes ->llseek just got into Linus' tree..
> 
> Well I still have this queued:

Yeah, that'll fix it.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
David Miller - Oct. 13, 2008, 4 a.m.
From: Andrew Morton <akpm@linux-foundation.org>
Date: Sun, 12 Oct 2008 19:11:13 -0700

> > On Sun, 12 Oct 2008 07:05:10 -0400 Christoph Hellwig <hch@infradead.org> wrote:
> > 
> > The bogus version which removes ->llseek just got into Linus' tree..
> 
> Well I still have this queued:
> 
> From: Andrew Morton <akpm@linux-foundation.org>
> 
> Cc: Andi Kleen <andi@firstfloor.org>
> Cc: Karsten Keil <kkeil@suse.de>
> Cc: Christoph Hellwig <hch@lst.de>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>

Andrew, want me to such this into my net-2.6 tree?
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Andrew Morton - Oct. 13, 2008, 11:56 a.m.
> On Sun, 12 Oct 2008 21:00:31 -0700 (PDT) David Miller <davem@davemloft.net> wrote:
> From: Andrew Morton <akpm@linux-foundation.org>
> Date: Sun, 12 Oct 2008 19:11:13 -0700
> 
> > > On Sun, 12 Oct 2008 07:05:10 -0400 Christoph Hellwig <hch@infradead.org> wrote:
> > > 
> > > The bogus version which removes ->llseek just got into Linus' tree..
> > 
> > Well I still have this queued:
> > 
> > From: Andrew Morton <akpm@linux-foundation.org>
> > 
> > Cc: Andi Kleen <andi@firstfloor.org>
> > Cc: Karsten Keil <kkeil@suse.de>
> > Cc: Christoph Hellwig <hch@lst.de>
> > Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> 
> Andrew, want me to such this into my net-2.6 tree?

yes please.  I'll send it over with a slight changelog.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
David Miller - Oct. 13, 2008, 6:47 p.m.
From: Andrew Morton <akpm@linux-foundation.org>
Date: Mon, 13 Oct 2008 04:56:58 -0700

> > On Sun, 12 Oct 2008 21:00:31 -0700 (PDT) David Miller <davem@davemloft.net> wrote:
> >
> > Andrew, want me to suck this into my net-2.6 tree?
> 
> yes please.  I'll send it over with a slight changelog.

Thanks, will pull those in.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff -puN drivers/isdn/mISDN/timerdev.c~misdn-misc-timerdev-fixes-fix drivers/isdn/mISDN/timerdev.c
--- a/drivers/isdn/mISDN/timerdev.c~misdn-misc-timerdev-fixes-fix
+++ a/drivers/isdn/mISDN/timerdev.c
@@ -61,7 +61,7 @@  mISDN_open(struct inode *ino, struct fil
 	init_waitqueue_head(&dev->wait);
 	filep->private_data = dev;
 	__module_get(THIS_MODULE);
-	return 0;
+	return nonseekable_open(ino, filep);
 }
 
 static int