diff mbox

[2/9] makedevs: Rework README

Message ID 1416068964-22529-2-git-send-email-maxime.hadjinlian@gmail.com
State Not Applicable
Headers show

Commit Message

Maxime Hadjinlian Nov. 15, 2014, 4:29 p.m. UTC
Make all the example as a space separated list.
The definition of the different type was modified to look like the same
section on the manual.

Signed-off-by: Maxime Hadjinlian <maxime.hadjinlian@gmail.com>
---
 package/makedevs/README | 18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)

Comments

Yann E. MORIN Nov. 19, 2014, 10:05 p.m. UTC | #1
Maxime, All,

On 2014-11-15 17:29 +0100, Maxime Hadjinlian spake thusly:
> Make all the example as a space separated list.
> The definition of the different type was modified to look like the same
> section on the manual.

That patch has already been applied by Peter on master, a full week
before you sent this setries.

When you re-spin a series, can you rebase on-top of the master current
at the time you send it, please, to avoid reviewers scratching their
head wondering what went wrong?

You owe me a beer at FOSDEM! :-p

Regards,
Yann E. MORIN.

> Signed-off-by: Maxime Hadjinlian <maxime.hadjinlian@gmail.com>
> ---
>  package/makedevs/README | 18 +++++++++---------
>  1 file changed, 9 insertions(+), 9 deletions(-)
> 
> diff --git a/package/makedevs/README b/package/makedevs/README
> index 6c54052..70844bf 100644
> --- a/package/makedevs/README
> +++ b/package/makedevs/README
> @@ -6,7 +6,7 @@ You can do all sorts of interesting things with a device table file.
>  For example, if you want to adjust the permissions on a particular
>  file you can just add an entry like:
>  
> -  /sbin/foobar        f       2755    0       0       -       -       -       -       -
> +  /sbin/foobar f 2755 0 0 - - - - -
>  
>  and (assuming the file /sbin/foobar exists) it will be made setuid
>  root (regardless of what its permissions are on the host filesystem.
> @@ -15,20 +15,20 @@ Furthermore, you can use a single table entry to create a many device
>  minors.  For example, if I wanted to create /dev/hda and
>  /dev/hda[0-15] I could just use the following two table entries:
>  
> -  /dev/hda    b       640     0       0       3       0       0       0       -
> -  /dev/hda    b       640     0       0       3       1       1       1       15
> +  /dev/hda b 640 0 0 3 0 0 0 -
> +  /dev/hda b 640 0 0 3 1 1 1 15
>  
>  Device table entries take the form of:
>  
> -<name>    <type>      <mode>  <uid>   <gid>   <major> <minor> <start> <inc>   <count>
> +<name> <type> <mode> <uid> <gid> <major> <minor> <start> <inc> <count>
>  
>  where name is the file name,  type can be one of:
>  
> -      f       A regular file
> -      d       Directory
> -      c       Character special device file
> -      b       Block special device file
> -      p       Fifo (named pipe)
> +      f: A regular file
> +      d: Directory
> +      c: Character special device file
> +      b: Block special device file
> +      p: Fifo (named pipe)
>  
>  uid is the user id for the target file, gid is the group id for the
>  target file.  The rest of the entries (major, minor, etc) apply only
> -- 
> 2.1.3
> 
> _______________________________________________
> buildroot mailing list
> buildroot@busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
Maxime Hadjinlian Nov. 24, 2014, 9:34 a.m. UTC | #2
Hi Yann, all

On Wed, Nov 19, 2014 at 11:05 PM, Yann E. MORIN <yann.morin.1998@free.fr> wrote:
> Maxime, All,
>
> On 2014-11-15 17:29 +0100, Maxime Hadjinlian spake thusly:
>> Make all the example as a space separated list.
>> The definition of the different type was modified to look like the same
>> section on the manual.
>
> That patch has already been applied by Peter on master, a full week
> before you sent this setries.
>
> When you re-spin a series, can you rebase on-top of the master current
> at the time you send it, please, to avoid reviewers scratching their
> head wondering what went wrong?
>
> You owe me a beer at FOSDEM! :-p
Arg ! Truly sorry about this one. I definitely owe you a beer :)
>
> Regards,
> Yann E. MORIN.
>
>> Signed-off-by: Maxime Hadjinlian <maxime.hadjinlian@gmail.com>
>> ---
>>  package/makedevs/README | 18 +++++++++---------
>>  1 file changed, 9 insertions(+), 9 deletions(-)
>>
>> diff --git a/package/makedevs/README b/package/makedevs/README
>> index 6c54052..70844bf 100644
>> --- a/package/makedevs/README
>> +++ b/package/makedevs/README
>> @@ -6,7 +6,7 @@ You can do all sorts of interesting things with a device table file.
>>  For example, if you want to adjust the permissions on a particular
>>  file you can just add an entry like:
>>
>> -  /sbin/foobar        f       2755    0       0       -       -       -       -       -
>> +  /sbin/foobar f 2755 0 0 - - - - -
>>
>>  and (assuming the file /sbin/foobar exists) it will be made setuid
>>  root (regardless of what its permissions are on the host filesystem.
>> @@ -15,20 +15,20 @@ Furthermore, you can use a single table entry to create a many device
>>  minors.  For example, if I wanted to create /dev/hda and
>>  /dev/hda[0-15] I could just use the following two table entries:
>>
>> -  /dev/hda    b       640     0       0       3       0       0       0       -
>> -  /dev/hda    b       640     0       0       3       1       1       1       15
>> +  /dev/hda b 640 0 0 3 0 0 0 -
>> +  /dev/hda b 640 0 0 3 1 1 1 15
>>
>>  Device table entries take the form of:
>>
>> -<name>    <type>      <mode>  <uid>   <gid>   <major> <minor> <start> <inc>   <count>
>> +<name> <type> <mode> <uid> <gid> <major> <minor> <start> <inc> <count>
>>
>>  where name is the file name,  type can be one of:
>>
>> -      f       A regular file
>> -      d       Directory
>> -      c       Character special device file
>> -      b       Block special device file
>> -      p       Fifo (named pipe)
>> +      f: A regular file
>> +      d: Directory
>> +      c: Character special device file
>> +      b: Block special device file
>> +      p: Fifo (named pipe)
>>
>>  uid is the user id for the target file, gid is the group id for the
>>  target file.  The rest of the entries (major, minor, etc) apply only
>> --
>> 2.1.3
>>
>> _______________________________________________
>> buildroot mailing list
>> buildroot@busybox.net
>> http://lists.busybox.net/mailman/listinfo/buildroot
>
> --
> .-----------------.--------------------.------------------.--------------------.
> |  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
> | +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
> | +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
> | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
> '------------------------------^-------^------------------^--------------------'
diff mbox

Patch

diff --git a/package/makedevs/README b/package/makedevs/README
index 6c54052..70844bf 100644
--- a/package/makedevs/README
+++ b/package/makedevs/README
@@ -6,7 +6,7 @@  You can do all sorts of interesting things with a device table file.
 For example, if you want to adjust the permissions on a particular
 file you can just add an entry like:
 
-  /sbin/foobar        f       2755    0       0       -       -       -       -       -
+  /sbin/foobar f 2755 0 0 - - - - -
 
 and (assuming the file /sbin/foobar exists) it will be made setuid
 root (regardless of what its permissions are on the host filesystem.
@@ -15,20 +15,20 @@  Furthermore, you can use a single table entry to create a many device
 minors.  For example, if I wanted to create /dev/hda and
 /dev/hda[0-15] I could just use the following two table entries:
 
-  /dev/hda    b       640     0       0       3       0       0       0       -
-  /dev/hda    b       640     0       0       3       1       1       1       15
+  /dev/hda b 640 0 0 3 0 0 0 -
+  /dev/hda b 640 0 0 3 1 1 1 15
 
 Device table entries take the form of:
 
-<name>    <type>      <mode>  <uid>   <gid>   <major> <minor> <start> <inc>   <count>
+<name> <type> <mode> <uid> <gid> <major> <minor> <start> <inc> <count>
 
 where name is the file name,  type can be one of:
 
-      f       A regular file
-      d       Directory
-      c       Character special device file
-      b       Block special device file
-      p       Fifo (named pipe)
+      f: A regular file
+      d: Directory
+      c: Character special device file
+      b: Block special device file
+      p: Fifo (named pipe)
 
 uid is the user id for the target file, gid is the group id for the
 target file.  The rest of the entries (major, minor, etc) apply only