From patchwork Mon Dec 14 12:48:22 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Isaku Yamahata X-Patchwork-Id: 41100 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id BF105B6F07 for ; Tue, 15 Dec 2009 00:08:02 +1100 (EST) Received: from localhost ([127.0.0.1]:45624 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NKAec-00039o-JV for incoming@patchwork.ozlabs.org; Mon, 14 Dec 2009 08:07:58 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NKAM8-0004zZ-6T for qemu-devel@nongnu.org; Mon, 14 Dec 2009 07:48:52 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NKAM1-0004wb-SG for qemu-devel@nongnu.org; Mon, 14 Dec 2009 07:48:49 -0500 Received: from [199.232.76.173] (port=57622 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NKAM1-0004wR-ON for qemu-devel@nongnu.org; Mon, 14 Dec 2009 07:48:45 -0500 Received: from mail.valinux.co.jp ([210.128.90.3]:34970) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NKAM0-0006Ko-8F for qemu-devel@nongnu.org; Mon, 14 Dec 2009 07:48:45 -0500 Received: from ps.local.valinux.co.jp (vagw.valinux.co.jp [210.128.90.14]) by mail.valinux.co.jp (Postfix) with SMTP id 80D2E4A4D1; Mon, 14 Dec 2009 21:48:36 +0900 (JST) Received: (nullmailer pid 30209 invoked by uid 1000); Mon, 14 Dec 2009 12:48:26 -0000 From: Isaku Yamahata To: qemu-devel@nongnu.org, mst@redhat.com Date: Mon, 14 Dec 2009 21:48:22 +0900 Message-Id: <1260794906-30168-8-git-send-email-yamahata@valinux.co.jp> X-Mailer: git-send-email 1.6.5.4 In-Reply-To: <1260794906-30168-1-git-send-email-yamahata@valinux.co.jp> References: <1260794906-30168-1-git-send-email-yamahata@valinux.co.jp> X-Virus-Scanned: clamav-milter 0.95.2 at va-mail.local.valinux.co.jp X-Virus-Status: Clean X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Cc: yamahata@valinux.co.jp Subject: [Qemu-devel] [PATCH 07/11] gt64xxx: remove gt64120_{read, write}_config(). X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org They call only pci_default_{read, write}_config(). So they aren't necessary. Signed-off-by: Isaku Yamahata Acked-by: Michael S. Tsirkin --- hw/gt64xxx.c | 13 +------------ 1 files changed, 1 insertions(+), 12 deletions(-) diff --git a/hw/gt64xxx.c b/hw/gt64xxx.c index fb7f5bd..c8034e2 100644 --- a/hw/gt64xxx.c +++ b/hw/gt64xxx.c @@ -1082,17 +1082,6 @@ static void gt64120_reset(void *opaque) gt64120_pci_mapping(s); } -static uint32_t gt64120_read_config(PCIDevice *d, uint32_t address, int len) -{ - return pci_default_read_config(d, address, len); -} - -static void gt64120_write_config(PCIDevice *d, uint32_t address, uint32_t val, - int len) -{ - pci_default_write_config(d, address, val, len); -} - static void gt64120_save(QEMUFile* f, void *opaque) { PCIDevice *d = opaque; @@ -1125,7 +1114,7 @@ PCIBus *pci_gt64120_init(qemu_irq *pic) pic, 144, 4); s->ISD_handle = cpu_register_io_memory(gt64120_read, gt64120_write, s); d = pci_register_device(s->pci->bus, "GT64120 PCI Bus", sizeof(PCIDevice), - 0, gt64120_read_config, gt64120_write_config); + 0, NULL, NULL); /* FIXME: Malta specific hw assumptions ahead */