Patchwork [04/11] pci: remove PCI_REVISION and PCI_SUBDEVICE_ID.

login
register
mail settings
Submitter Isaku Yamahata
Date Dec. 14, 2009, 12:48 p.m.
Message ID <1260794906-30168-5-git-send-email-yamahata@valinux.co.jp>
Download mbox | patch
Permalink /patch/41094/
State New
Headers show

Comments

Isaku Yamahata - Dec. 14, 2009, 12:48 p.m.
There is no user and they're obsolete. So remove them.

Signed-off-by: Isaku Yamahata <yamahata@valinux.co.jp>
---
 hw/pci.h |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)
Michael S. Tsirkin - Dec. 14, 2009, 1:53 p.m.
On Mon, Dec 14, 2009 at 09:48:19PM +0900, Isaku Yamahata wrote:
> There is no user and they're obsolete. So remove them.
> 
> Signed-off-by: Isaku Yamahata <yamahata@valinux.co.jp>

We are removing everything here later, is it worth it
to put in a separate patch?
Anyway:
Acked-by: Michael S. Tsirkin <mst@redhat.com>

> ---
>  hw/pci.h |    2 --
>  1 files changed, 0 insertions(+), 2 deletions(-)
> 
> diff --git a/hw/pci.h b/hw/pci.h
> index 0309674..91f3809 100644
> --- a/hw/pci.h
> +++ b/hw/pci.h
> @@ -154,9 +154,7 @@ typedef struct PCIIORegion {
>  #define PCI_CAP_LIST_ID		0	/* Capability ID */
>  #define PCI_CAP_LIST_NEXT	1	/* Next capability in the list */
>  
> -#define PCI_REVISION            0x08    /* obsolete, use PCI_REVISION_ID */
>  #define PCI_SUBSYSTEM_VENDOR_ID 0x2c
> -#define PCI_SUBDEVICE_ID        0x2e    /* obsolete, use PCI_SUBSYSTEM_ID */
>  
>  /* Bits in the PCI Status Register (PCI 2.3 spec) */
>  #define PCI_STATUS_RESERVED1	0x007
> -- 
> 1.6.5.4

Patch

diff --git a/hw/pci.h b/hw/pci.h
index 0309674..91f3809 100644
--- a/hw/pci.h
+++ b/hw/pci.h
@@ -154,9 +154,7 @@  typedef struct PCIIORegion {
 #define PCI_CAP_LIST_ID		0	/* Capability ID */
 #define PCI_CAP_LIST_NEXT	1	/* Next capability in the list */
 
-#define PCI_REVISION            0x08    /* obsolete, use PCI_REVISION_ID */
 #define PCI_SUBSYSTEM_VENDOR_ID 0x2c
-#define PCI_SUBDEVICE_ID        0x2e    /* obsolete, use PCI_SUBSYSTEM_ID */
 
 /* Bits in the PCI Status Register (PCI 2.3 spec) */
 #define PCI_STATUS_RESERVED1	0x007