Patchwork [08/11] acpi: use range helper function.

login
register
mail settings
Submitter Isaku Yamahata
Date Dec. 14, 2009, 12:48 p.m.
Message ID <1260794906-30168-9-git-send-email-yamahata@valinux.co.jp>
Download mbox | patch
Permalink /patch/41092/
State New
Headers show

Comments

Isaku Yamahata - Dec. 14, 2009, 12:48 p.m.
use range helper function in pm_write_config().

Signed-off-by: Isaku Yamahata <yamahata@valinux.co.jp>
---
 hw/acpi.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Michael S. Tsirkin - Dec. 14, 2009, 1:37 p.m.
On Mon, Dec 14, 2009 at 09:48:23PM +0900, Isaku Yamahata wrote:
> use range helper function in pm_write_config().
> 
> Signed-off-by: Isaku Yamahata <yamahata@valinux.co.jp>

Acked-by: Michael S. Tsirkin <mst@redhat.com>

> ---
>  hw/acpi.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/hw/acpi.c b/hw/acpi.c
> index 9a69e7d..ad72297 100644
> --- a/hw/acpi.c
> +++ b/hw/acpi.c
> @@ -437,7 +437,7 @@ static void pm_write_config(PCIDevice *d,
>                              uint32_t address, uint32_t val, int len)
>  {
>      pci_default_write_config(d, address, val, len);
> -    if (address == 0x80)
> +    if (range_covers_byte(address, len, 0x80))
>          pm_io_space_update((PIIX4PMState *)d);
>  }
>  
> -- 
> 1.6.5.4

Patch

diff --git a/hw/acpi.c b/hw/acpi.c
index 9a69e7d..ad72297 100644
--- a/hw/acpi.c
+++ b/hw/acpi.c
@@ -437,7 +437,7 @@  static void pm_write_config(PCIDevice *d,
                             uint32_t address, uint32_t val, int len)
 {
     pci_default_write_config(d, address, val, len);
-    if (address == 0x80)
+    if (range_covers_byte(address, len, 0x80))
         pm_io_space_update((PIIX4PMState *)d);
 }