From patchwork Mon Dec 14 09:39:12 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Weil X-Patchwork-Id: 41073 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id DE9E2B6F1C for ; Mon, 14 Dec 2009 20:40:18 +1100 (EST) Received: from localhost ([127.0.0.1]:42017 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NK7Pa-0005QZ-Vo for incoming@patchwork.ozlabs.org; Mon, 14 Dec 2009 04:40:15 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NK7Ou-0005Mi-PJ for qemu-devel@nongnu.org; Mon, 14 Dec 2009 04:39:32 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NK7Op-0005FP-Ga for qemu-devel@nongnu.org; Mon, 14 Dec 2009 04:39:31 -0500 Received: from [199.232.76.173] (port=47707 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NK7Op-0005F9-8m for qemu-devel@nongnu.org; Mon, 14 Dec 2009 04:39:27 -0500 Received: from moutng.kundenserver.de ([212.227.126.187]:54819) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NK7Oo-0007rg-Ol for qemu-devel@nongnu.org; Mon, 14 Dec 2009 04:39:27 -0500 Received: from flocke.weilnetz.de (p54ADF777.dip.t-dialin.net [84.173.247.119]) by mrelayeu.kundenserver.de (node=mreu2) with ESMTP (Nemesis) id 0Mhgu7-1NfvNP2dW7-00MvKf; Mon, 14 Dec 2009 10:39:16 +0100 Received: from stefan by flocke.weilnetz.de with local (Exim 4.69) (envelope-from ) id 1NK7Od-0003P3-Hd; Mon, 14 Dec 2009 10:39:15 +0100 From: Stefan Weil To: QEMU Developers , Alexander Graf , Aurelien Jarno Date: Mon, 14 Dec 2009 10:39:12 +0100 Message-Id: <1260783552-13025-1-git-send-email-weil@mail.berlios.de> X-Mailer: git-send-email 1.6.5 X-Provags-ID: V01U2FsdGVkX1+ptGB1zJI5uLBqjc5v91lEiQmw6F4AS2TFh9g t03NUgtkMX+HbWFe+tVSb43O080leMq6YZNsljK2OZKgU07cCo pNKVnmvSXeVyo6Uunt/S5oLJCSAmOJ52uVwSD6XelmPoVqqXB5 X9g== X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. Cc: Subject: [Qemu-devel] [PATCH] s390: Fix buggy assignment X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org nd->model keeps dynamically allocated model names. So casting of a constant string is wrong here. Signed-off-by: Stefan Weil Acked-by: Alexander Graf --- hw/s390-virtio.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/s390-virtio.c b/hw/s390-virtio.c index b567886..b57fa9c 100644 --- a/hw/s390-virtio.c +++ b/hw/s390-virtio.c @@ -209,7 +209,7 @@ static void s390_init(ram_addr_t ram_size, DeviceState *dev; if (!nd->model) { - nd->model = (char*)"virtio"; + nd->model = qemu_strdup("virtio"); } if (strcmp(nd->model, "virtio")) {