| Message ID | 1415908080-19350-1-git-send-email-iawillia@us.ibm.com |
|---|---|
| State | Rejected |
| Headers | show |
On 13/11/14 20:48, Patrick Williams wrote: > Github changed the URL syntax from 'archive' back to 'tarball'. > > Signed-off-by: Patrick Williams <iawillia@us.ibm.com> > --- > package/pkg-download.mk | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/package/pkg-download.mk b/package/pkg-download.mk > index 4cfb913..03907f1 100644 > --- a/package/pkg-download.mk > +++ b/package/pkg-download.mk > @@ -56,7 +56,7 @@ notdomain=$(patsubst $(call domain,$(1),$(2))$(call domainseparator,$(2))%,%,$(c > domainseparator=$(if $(1),$(1),/) > > # github(user,package,version): returns site of GitHub repository > -github = https://github.com/$(1)/$(2)/archive/$(3) > +github = https://github.com/$(1)/$(2)/tarball/$(3) > > ################################################################################ > # The DOWNLOAD_* helpers are in charge of getting a working copy > Yep, that seems to work! So Yann, stop working :-) I haven't tested if it's exactly the same tarball. It redirects to a URL containing legacy.tar.gz instead of tar.gz, so who knows... Regards, Arnout
On 13/11/14 20:58, Arnout Vandecappelle wrote: > On 13/11/14 20:48, Patrick Williams wrote: >> Github changed the URL syntax from 'archive' back to 'tarball'. >> >> Signed-off-by: Patrick Williams <iawillia@us.ibm.com> >> --- >> package/pkg-download.mk | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/package/pkg-download.mk b/package/pkg-download.mk >> index 4cfb913..03907f1 100644 >> --- a/package/pkg-download.mk >> +++ b/package/pkg-download.mk >> @@ -56,7 +56,7 @@ notdomain=$(patsubst $(call domain,$(1),$(2))$(call domainseparator,$(2))%,%,$(c >> domainseparator=$(if $(1),$(1),/) >> >> # github(user,package,version): returns site of GitHub repository >> -github = https://github.com/$(1)/$(2)/archive/$(3) >> +github = https://github.com/$(1)/$(2)/tarball/$(3) >> >> ################################################################################ >> # The DOWNLOAD_* helpers are in charge of getting a working copy >> > > Yep, that seems to work! So Yann, stop working :-) > > I haven't tested if it's exactly the same tarball. It redirects to a URL > containing legacy.tar.gz instead of tar.gz, so who knows... Checked with a few tarballs, and it seems they only differ in the basename: legacy (i.e., this patch): zeromq-cppzmq-1f05e0d/ current (i.e., archive/version.tar.gz): cppzmq-1f05e0d111197c64be32ad5aecd59f4d1b05a819/ So the legacy really looks better :-) Therefore: Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be> Tested-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be> Regards, Arnout
On Thu, Nov 13, 2014 at 8:58 PM, Arnout Vandecappelle <arnout@mind.be> wrote: > On 13/11/14 20:48, Patrick Williams wrote: >> Github changed the URL syntax from 'archive' back to 'tarball'. >> >> Signed-off-by: Patrick Williams <iawillia@us.ibm.com> >> --- >> package/pkg-download.mk | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/package/pkg-download.mk b/package/pkg-download.mk >> index 4cfb913..03907f1 100644 >> --- a/package/pkg-download.mk >> +++ b/package/pkg-download.mk >> @@ -56,7 +56,7 @@ notdomain=$(patsubst $(call domain,$(1),$(2))$(call domainseparator,$(2))%,%,$(c >> domainseparator=$(if $(1),$(1),/) >> >> # github(user,package,version): returns site of GitHub repository >> -github = https://github.com/$(1)/$(2)/archive/$(3) >> +github = https://github.com/$(1)/$(2)/tarball/$(3) >> >> ################################################################################ >> # The DOWNLOAD_* helpers are in charge of getting a working copy >> > > Yep, that seems to work! So Yann, stop working :-) > > I haven't tested if it's exactly the same tarball. It redirects to a URL > containing legacy.tar.gz instead of tar.gz, so who knows... I can't follow all this madness. >>> a10disp a899cc6dcf909360aac00482ede5369f3656f226 Downloading --2014-11-13 20:57:54-- https://github.com/hglm/a10disp/archive/a899cc6dcf909360aac00482ede5369f3656f226/a10disp-a899cc6dcf909360aac00482ede5369f3656f226.tar.gz Resolving github.com (github.com)... 192.30.252.129 Connecting to github.com (github.com)|192.30.252.129|:443... connected. HTTP request sent, awaiting response... 302 Found Location: https://codeload.github.com/hglm/a10disp/tar.gz/a899cc6dcf909360aac00482ede5369f3656f226 [following] --2014-11-13 20:57:54-- https://codeload.github.com/hglm/a10disp/tar.gz/a899cc6dcf909360aac00482ede5369f3656f226 Resolving codeload.github.com (codeload.github.com)... 192.30.252.146 Connecting to codeload.github.com (codeload.github.com)|192.30.252.146|:443... connected. HTTP request sent, awaiting response... 200 OK Length: unspecified [application/x-gzip] Here the original URL with 'archive' still works. So what's the fuzz about?
On 13/11/14 21:06, Thomas De Schampheleire wrote: > On Thu, Nov 13, 2014 at 8:58 PM, Arnout Vandecappelle <arnout@mind.be> wrote: >> On 13/11/14 20:48, Patrick Williams wrote: >>> Github changed the URL syntax from 'archive' back to 'tarball'. >>> >>> Signed-off-by: Patrick Williams <iawillia@us.ibm.com> >>> --- >>> package/pkg-download.mk | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/package/pkg-download.mk b/package/pkg-download.mk >>> index 4cfb913..03907f1 100644 >>> --- a/package/pkg-download.mk >>> +++ b/package/pkg-download.mk >>> @@ -56,7 +56,7 @@ notdomain=$(patsubst $(call domain,$(1),$(2))$(call domainseparator,$(2))%,%,$(c >>> domainseparator=$(if $(1),$(1),/) >>> >>> # github(user,package,version): returns site of GitHub repository >>> -github = https://github.com/$(1)/$(2)/archive/$(3) >>> +github = https://github.com/$(1)/$(2)/tarball/$(3) >>> >>> ################################################################################ >>> # The DOWNLOAD_* helpers are in charge of getting a working copy >>> >> >> Yep, that seems to work! So Yann, stop working :-) >> >> I haven't tested if it's exactly the same tarball. It redirects to a URL >> containing legacy.tar.gz instead of tar.gz, so who knows... > > I can't follow all this madness. > >>>> a10disp a899cc6dcf909360aac00482ede5369f3656f226 Downloading > --2014-11-13 20:57:54-- > https://github.com/hglm/a10disp/archive/a899cc6dcf909360aac00482ede5369f3656f226/a10disp-a899cc6dcf909360aac00482ede5369f3656f226.tar.gz > Resolving github.com (github.com)... 192.30.252.129 > Connecting to github.com (github.com)|192.30.252.129|:443... connected. > HTTP request sent, awaiting response... 302 Found > Location: https://codeload.github.com/hglm/a10disp/tar.gz/a899cc6dcf909360aac00482ede5369f3656f226 > [following] > --2014-11-13 20:57:54-- > https://codeload.github.com/hglm/a10disp/tar.gz/a899cc6dcf909360aac00482ede5369f3656f226 > Resolving codeload.github.com (codeload.github.com)... 192.30.252.146 > Connecting to codeload.github.com > (codeload.github.com)|192.30.252.146|:443... connected. > HTTP request sent, awaiting response... 200 OK > Length: unspecified [application/x-gzip] > > Here the original URL with 'archive' still works. So what's the fuzz about? > > I guess someone complained to github and they reverted it... I just tried https://github.com/xbmc/xbmc/archive/13.2-Gotham/xbmc-13.2-Gotham.tar.gz which failed for Peter this morning, and it works now. The funny thing is, it _doesn't_ redirect to the legacy... Regards, Arnout
On Thu, Nov 13, 2014 at 9:06 PM, Thomas De Schampheleire <patrickdepinguin@gmail.com> wrote: > On Thu, Nov 13, 2014 at 8:58 PM, Arnout Vandecappelle <arnout@mind.be> wrote: >> On 13/11/14 20:48, Patrick Williams wrote: >>> Github changed the URL syntax from 'archive' back to 'tarball'. >>> >>> Signed-off-by: Patrick Williams <iawillia@us.ibm.com> >>> --- >>> package/pkg-download.mk | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/package/pkg-download.mk b/package/pkg-download.mk >>> index 4cfb913..03907f1 100644 >>> --- a/package/pkg-download.mk >>> +++ b/package/pkg-download.mk >>> @@ -56,7 +56,7 @@ notdomain=$(patsubst $(call domain,$(1),$(2))$(call domainseparator,$(2))%,%,$(c >>> domainseparator=$(if $(1),$(1),/) >>> >>> # github(user,package,version): returns site of GitHub repository >>> -github = https://github.com/$(1)/$(2)/archive/$(3) >>> +github = https://github.com/$(1)/$(2)/tarball/$(3) >>> >>> ################################################################################ >>> # The DOWNLOAD_* helpers are in charge of getting a working copy >>> >> >> Yep, that seems to work! So Yann, stop working :-) >> >> I haven't tested if it's exactly the same tarball. It redirects to a URL >> containing legacy.tar.gz instead of tar.gz, so who knows... > > I can't follow all this madness. It seems people at github are like weathervane... ;-) http://git.buildroot.net/buildroot/commit/?id=507d6a637ba51e9799acd4c8a0b614fc9842b4e2
Thomas, Arnout, Patrick, All, On 2014-11-13 21:06 +0100, Thomas De Schampheleire spake thusly: > On Thu, Nov 13, 2014 at 8:58 PM, Arnout Vandecappelle <arnout@mind.be> wrote: > > On 13/11/14 20:48, Patrick Williams wrote: > >> Github changed the URL syntax from 'archive' back to 'tarball'. > >> > >> Signed-off-by: Patrick Williams <iawillia@us.ibm.com> > >> --- > >> package/pkg-download.mk | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > >> > >> diff --git a/package/pkg-download.mk b/package/pkg-download.mk > >> index 4cfb913..03907f1 100644 > >> --- a/package/pkg-download.mk > >> +++ b/package/pkg-download.mk > >> @@ -56,7 +56,7 @@ notdomain=$(patsubst $(call domain,$(1),$(2))$(call domainseparator,$(2))%,%,$(c > >> domainseparator=$(if $(1),$(1),/) > >> > >> # github(user,package,version): returns site of GitHub repository > >> -github = https://github.com/$(1)/$(2)/archive/$(3) > >> +github = https://github.com/$(1)/$(2)/tarball/$(3) > >> > >> ################################################################################ > >> # The DOWNLOAD_* helpers are in charge of getting a working copy > >> > > > > Yep, that seems to work! So Yann, stop working :-) Meh... > > I haven't tested if it's exactly the same tarball. It redirects to a URL > > containing legacy.tar.gz instead of tar.gz, so who knows... > > I can't follow all this madness. > > >>> a10disp a899cc6dcf909360aac00482ede5369f3656f226 Downloading > --2014-11-13 20:57:54-- > https://github.com/hglm/a10disp/archive/a899cc6dcf909360aac00482ede5369f3656f226/a10disp-a899cc6dcf909360aac00482ede5369f3656f226.tar.gz > Resolving github.com (github.com)... 192.30.252.129 > Connecting to github.com (github.com)|192.30.252.129|:443... connected. > HTTP request sent, awaiting response... 302 Found > Location: https://codeload.github.com/hglm/a10disp/tar.gz/a899cc6dcf909360aac00482ede5369f3656f226 > [following] > --2014-11-13 20:57:54-- > https://codeload.github.com/hglm/a10disp/tar.gz/a899cc6dcf909360aac00482ede5369f3656f226 > Resolving codeload.github.com (codeload.github.com)... 192.30.252.146 > Connecting to codeload.github.com > (codeload.github.com)|192.30.252.146|:443... connected. > HTTP request sent, awaiting response... 200 OK > Length: unspecified [application/x-gzip] > > Here the original URL with 'archive' still works. So what's the fuzz about? DAng... It works again. It surely was broken yesterday: all downlaod would fallback to using http://sources.buildroot.net See also the mail from Peter stating it did not work for him, too: http://lists.busybox.net/pipermail/buildroot/2014-November/111953.html So, they "fixed" it over-night. Sigh, that's not reliable. OK, so we can probably post-pone the resolution for post-release. Regards, Yann E. MORIN.
>>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes: Hi, >> Here the original URL with 'archive' still works. So what's the fuzz about? > DAng... It works again. It surely was broken yesterday: all downlaod > would fallback to using http://sources.buildroot.net > See also the mail from Peter stating it did not work for him, too: > http://lists.busybox.net/pipermail/buildroot/2014-November/111953.html > So, they "fixed" it over-night. Sigh, that's not reliable. > OK, so we can probably post-pone the resolution for post-release. Gaah, I lost track. Are we now keeping it like it is or do we go back to the /tarball/ URLs?
Hi Peter, On Fri, Nov 14, 2014 at 4:13 PM, Peter Korsgaard <peter@korsgaard.com> wrote: >>>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes: > > Hi, > > >> Here the original URL with 'archive' still works. So what's the fuzz about? > > > DAng... It works again. It surely was broken yesterday: all downlaod > > would fallback to using http://sources.buildroot.net > > > See also the mail from Peter stating it did not work for him, too: > > http://lists.busybox.net/pipermail/buildroot/2014-November/111953.html > > > So, they "fixed" it over-night. Sigh, that's not reliable. > > > OK, so we can probably post-pone the resolution for post-release. > > Gaah, I lost track. Are we now keeping it like it is or do we go back to > the /tarball/ URLs? We keep things as is for now, No fix is needed on Buildroot side, it has been done on github side. Regards,
>>>>> "Samuel" == Samuel Martin <s.martin49@gmail.com> writes: Hi, >> Gaah, I lost track. Are we now keeping it like it is or do we go back to >> the /tarball/ URLs? > We keep things as is for now, > No fix is needed on Buildroot side, it has been done on github side. Ok, thanks.
diff --git a/package/pkg-download.mk b/package/pkg-download.mk index 4cfb913..03907f1 100644 --- a/package/pkg-download.mk +++ b/package/pkg-download.mk @@ -56,7 +56,7 @@ notdomain=$(patsubst $(call domain,$(1),$(2))$(call domainseparator,$(2))%,%,$(c domainseparator=$(if $(1),$(1),/) # github(user,package,version): returns site of GitHub repository -github = https://github.com/$(1)/$(2)/archive/$(3) +github = https://github.com/$(1)/$(2)/tarball/$(3) ################################################################################ # The DOWNLOAD_* helpers are in charge of getting a working copy
Github changed the URL syntax from 'archive' back to 'tarball'. Signed-off-by: Patrick Williams <iawillia@us.ibm.com> --- package/pkg-download.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)