diff mbox

[v2] Fix libtool.m4 for Darwin >= 10.10

Message ID AABA69FD-01FA-4A96-97F8-B6A618C4CB78@gmail.com
State New
Headers show

Commit Message

FX Coudert Nov. 12, 2014, 12:32 p.m. UTC 
> Thanks everyone for the comments and review.
> Committed as r217366

I cannot push the change to binutils-gdb as I don’t have write access there.
Also, Joseph Myers said I needed to commit to newlib/libgloss, but their webpage only mentions read-only CVS.

Could someone do it for me?

Thanks,
FX




commit 8d25b840ce688bfa601b0ad5f53c4185627c8975
Author: FX <fxcoudert@gmail.com>
Date:   Wed Nov 12 13:26:06 2014 +0100

        * libtool.m4: Fix globbing of darwin versions.

Comments

FX Coudert Nov. 24, 2014, 5:04 p.m. UTC | #1 
*ping*

Didn’t get any response to my question so far…


>> Thanks everyone for the comments and review.
>> Committed as r217366
> 
> I cannot push the change to binutils-gdb as I don’t have write access there.
> Also, Joseph Myers said I needed to commit to newlib/libgloss, but their webpage only mentions read-only CVS.
> 
> Could someone do it for me?
> 
> Thanks,
> FX
> 
> 
> 
> 
> commit 8d25b840ce688bfa601b0ad5f53c4185627c8975
> Author: FX <fxcoudert@gmail.com>
> Date:   Wed Nov 12 13:26:06 2014 +0100
> 
>        * libtool.m4: Fix globbing of darwin versions.
> 
> diff --git a/ChangeLog b/ChangeLog
> index 32b3c15..5ed8242 100644
> --- a/ChangeLog
> +++ b/ChangeLog
> @@ -1,3 +1,7 @@
> +2014-11-12  Francois-Xavier Coudert  <fxcoudert@gcc.gnu.org>
> +
> +       * libtool.m4: Fix globbing of darwin versions.
> +
> 2014-10-15  Tristan Gingold  <gingold@adacore.com>
> 
>        * src-release.sh (do_proto_toplev): Configure with --target.
> diff --git a/libtool.m4 b/libtool.m4
> index 797468f..c96d80c 100644
> --- a/libtool.m4
> +++ b/libtool.m4
> @@ -1006,7 +1006,7 @@ _LT_EOF
>       case ${MACOSX_DEPLOYMENT_TARGET-10.0},$host in
>        10.0,*86*-darwin8*|10.0,*-darwin[[91]]*)
>          _lt_dar_allow_undefined='${wl}-undefined ${wl}dynamic_lookup' ;;
> -       10.[[012]]*)
> +       10.[[012]][[,.]]*)
>          _lt_dar_allow_undefined='${wl}-flat_namespace ${wl}-undefined ${wl}sup
>        10.*)
>          _lt_dar_allow_undefined='${wl}-undefined ${wl}dynamic_lookup' ;;
>
H.J. Lu Nov. 24, 2014, 5:17 p.m. UTC | #2 
Done:

https://sourceware.org/ml/binutils/2014-11/msg00318.html

On Mon, Nov 24, 2014 at 9:04 AM, FX <fxcoudert@gmail.com> wrote:
> *ping*
>
> Didn’t get any response to my question so far…
>
>
>>> Thanks everyone for the comments and review.
>>> Committed as r217366
>>
>> I cannot push the change to binutils-gdb as I don’t have write access there.
>> Also, Joseph Myers said I needed to commit to newlib/libgloss, but their webpage only mentions read-only CVS.
>>
>> Could someone do it for me?
>>
>> Thanks,
>> FX
>>
>>
>>
>>
>> commit 8d25b840ce688bfa601b0ad5f53c4185627c8975
>> Author: FX <fxcoudert@gmail.com>
>> Date:   Wed Nov 12 13:26:06 2014 +0100
>>
>>        * libtool.m4: Fix globbing of darwin versions.
>>
>> diff --git a/ChangeLog b/ChangeLog
>> index 32b3c15..5ed8242 100644
>> --- a/ChangeLog
>> +++ b/ChangeLog
>> @@ -1,3 +1,7 @@
>> +2014-11-12  Francois-Xavier Coudert  <fxcoudert@gcc.gnu.org>
>> +
>> +       * libtool.m4: Fix globbing of darwin versions.
>> +
>> 2014-10-15  Tristan Gingold  <gingold@adacore.com>
>>
>>        * src-release.sh (do_proto_toplev): Configure with --target.
>> diff --git a/libtool.m4 b/libtool.m4
>> index 797468f..c96d80c 100644
>> --- a/libtool.m4
>> +++ b/libtool.m4
>> @@ -1006,7 +1006,7 @@ _LT_EOF
>>       case ${MACOSX_DEPLOYMENT_TARGET-10.0},$host in
>>        10.0,*86*-darwin8*|10.0,*-darwin[[91]]*)
>>          _lt_dar_allow_undefined='${wl}-undefined ${wl}dynamic_lookup' ;;
>> -       10.[[012]]*)
>> +       10.[[012]][[,.]]*)
>>          _lt_dar_allow_undefined='${wl}-flat_namespace ${wl}-undefined ${wl}sup
>>        10.*)
>>          _lt_dar_allow_undefined='${wl}-undefined ${wl}dynamic_lookup' ;;
>>
>
FX Coudert Nov. 24, 2014, 5:55 p.m. UTC | #3 
> Done:
> https://sourceware.org/ml/binutils/2014-11/msg00318.html

Thanks!
diff mbox

Patch

diff --git a/ChangeLog b/ChangeLog
index 32b3c15..5ed8242 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,7 @@ 
+2014-11-12  Francois-Xavier Coudert  <fxcoudert@gcc.gnu.org>
+
+       * libtool.m4: Fix globbing of darwin versions.
+
 2014-10-15  Tristan Gingold  <gingold@adacore.com>
 
        * src-release.sh (do_proto_toplev): Configure with --target.
diff --git a/libtool.m4 b/libtool.m4
index 797468f..c96d80c 100644
--- a/libtool.m4
+++ b/libtool.m4
@@ -1006,7 +1006,7 @@  _LT_EOF
       case ${MACOSX_DEPLOYMENT_TARGET-10.0},$host in
        10.0,*86*-darwin8*|10.0,*-darwin[[91]]*)
          _lt_dar_allow_undefined='${wl}-undefined ${wl}dynamic_lookup' ;;
-       10.[[012]]*)
+       10.[[012]][[,.]]*)
          _lt_dar_allow_undefined='${wl}-flat_namespace ${wl}-undefined ${wl}sup
        10.*)
          _lt_dar_allow_undefined='${wl}-undefined ${wl}dynamic_lookup' ;;