diff mbox

[U-Boot] cros_ec: Fix uninitialised variable in cros_ec.c

Message ID 1415754390-24781-1-git-send-email-sjg@chromium.org
State Accepted
Delegated to: Simon Glass
Headers show

Commit Message

Simon Glass Nov. 12, 2014, 1:06 a.m. UTC 
This fixes this cppcheck report:

[drivers/misc/cros_ec.c:704]: (error) Uninitialized variable: req

Signed-off-by: Simon Glass <sjg@chromium.org>
Reported-by: Wolfgang Denk <wd@denx.de>
---

 drivers/misc/cros_ec.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Simon Glass Nov. 23, 2014, 1 p.m. UTC | #1 
On 12 November 2014 at 02:06, Simon Glass <sjg@chromium.org> wrote:
> This fixes this cppcheck report:
>
> [drivers/misc/cros_ec.c:704]: (error) Uninitialized variable: req
>
> Signed-off-by: Simon Glass <sjg@chromium.org>
> Reported-by: Wolfgang Denk <wd@denx.de>

Applied to u-boot-dm.
diff mbox

Patch

diff --git a/drivers/misc/cros_ec.c b/drivers/misc/cros_ec.c
index 521edfd..9b4effb 100644
--- a/drivers/misc/cros_ec.c
+++ b/drivers/misc/cros_ec.c
@@ -701,6 +701,7 @@  static int cros_ec_check_version(struct cros_ec_dev *dev)
 
 	/* Try sending a version 3 packet */
 	dev->protocol_version = 3;
+	req.in_data = 0;
 	if (ec_command_inptr(dev, EC_CMD_HELLO, 0, &req, sizeof(req),
 			     (uint8_t **)&resp, sizeof(*resp)) > 0) {
 		return 0;