| Submitter | Ajit Khaparde |
|---|---|
| Date | Dec. 12, 2009, 1:38 a.m. |
| Message ID | <20091212013847.GA10922@serverengines.com> |
| Download | mbox | patch |
| Permalink | /patch/40941/ |
| State | Accepted |
| Delegated to: | David Miller |
| Headers | show |
Comments
From: Ajit Khaparde <ajitk@serverengines.com> Date: Sat, 12 Dec 2009 07:08:49 +0530 > There are certain skews of the NIC which have multiple bits set in adapter->cap. > Use & instead of == to process rx completions. > > Signed-off-by: Ajit Khaparde <ajitk@serverengines.com> Applied. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Patch
diff --git a/drivers/net/benet/be_main.c b/drivers/net/benet/be_main.c index 957a0f7..8959bc7 100644 --- a/drivers/net/benet/be_main.c +++ b/drivers/net/benet/be_main.c @@ -759,7 +759,7 @@ static void be_rx_compl_process(struct be_adapter *adapter, /* vlanf could be wrongly set in some cards. * ignore if vtm is not set */ - if ((adapter->cap == 0x400) && !vtm) + if ((adapter->cap & 0x400) && !vtm) vlanf = 0; skb = netdev_alloc_skb_ip_align(adapter->netdev, BE_HDR_LEN); @@ -816,7 +816,7 @@ static void be_rx_compl_process_gro(struct be_adapter *adapter, /* vlanf could be wrongly set in some cards. * ignore if vtm is not set */ - if ((adapter->cap == 0x400) && !vtm) + if ((adapter->cap & 0x400) && !vtm) vlanf = 0; skb = napi_get_frags(&eq_obj->napi);
There are certain skews of the NIC which have multiple bits set in adapter->cap. Use & instead of == to process rx completions. Signed-off-by: Ajit Khaparde <ajitk@serverengines.com> --- drivers/net/benet/be_main.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)