diff mbox

net: smc91x: Fix up type mismatch in smc_drv_resume().

Message ID 20091211064226.GA7625@linux-sh.org
State Accepted, archived
Delegated to: David Miller
Headers show

Commit Message

Paul Mundt Dec. 11, 2009, 6:42 a.m. UTC
smc_drv_resume() takes a struct device, while smc_enable_device() takes a
platform device. This fixes up the smc_enable_device() callsite with the
proper pointer.

It's not obvious when this change was introduced, as git history doesn't
go back that far. Presumably the resume code has always been broken in
this fashion.

Signed-off-by: Paul Mundt <lethal@linux-sh.org>

---

 drivers/net/smc91x.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

David Miller Dec. 11, 2009, 11:17 p.m. UTC | #1
From: Paul Mundt <lethal@linux-sh.org>
Date: Fri, 11 Dec 2009 15:42:27 +0900

> smc_drv_resume() takes a struct device, while smc_enable_device() takes a
> platform device. This fixes up the smc_enable_device() callsite with the
> proper pointer.
> 
> It's not obvious when this change was introduced, as git history doesn't
> go back that far. Presumably the resume code has always been broken in
> this fashion.
> 
> Signed-off-by: Paul Mundt <lethal@linux-sh.org>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/net/smc91x.c b/drivers/net/smc91x.c
index ae4983a..5c9222d 100644
--- a/drivers/net/smc91x.c
+++ b/drivers/net/smc91x.c
@@ -2387,7 +2387,7 @@  static int smc_drv_resume(struct device *dev)
 
 	if (ndev) {
 		struct smc_local *lp = netdev_priv(ndev);
-		smc_enable_device(dev);
+		smc_enable_device(pdev);
 		if (netif_running(ndev)) {
 			smc_reset(ndev);
 			smc_enable(ndev);