diff mbox

[U-Boot] ARM: OMAP5: DRA7xx: Fix misleading comments in mux_data.h

Message ID f6f2d22b859237009b76ab1138cf6e9e.squirrel@www.mm-sol.com
State Accepted
Delegated to: Tom Rini
Headers show

Commit Message

Lubomir Popov Nov. 10, 2014, 4:34 p.m. UTC
The comments on the QSPI pad assignments erronously swapped
the qspi1_d0 and qspi1_d1 functionality and could cause
confusion. QSPI1_D[0] is in fact muxed on pad U1 (gpmc_a16),
and QSPI1_D[1] - on pad P3 (gpmc_a17). Fixing comments.

Signed-off-by: Lubomir Popov <l-popov@ti.com>
---
 board/ti/dra7xx/mux_data.h |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Tom Rini Nov. 10, 2014, 6:45 p.m. UTC | #1
On Mon, Nov 10, 2014 at 06:34:10PM +0200, Lubomir Popov wrote:
> The comments on the QSPI pad assignments erronously swapped
> the qspi1_d0 and qspi1_d1 functionality and could cause
> confusion. QSPI1_D[0] is in fact muxed on pad U1 (gpmc_a16),
> and QSPI1_D[1] - on pad P3 (gpmc_a17). Fixing comments.
> 
> Signed-off-by: Lubomir Popov <l-popov@ti.com>

Reviewed-by: Tom Rini <trini@ti.com>
Tom Rini Dec. 5, 2014, 2:53 p.m. UTC | #2
On Mon, Nov 10, 2014 at 06:34:10PM +0200, Lubomir Popov wrote:

> The comments on the QSPI pad assignments erronously swapped
> the qspi1_d0 and qspi1_d1 functionality and could cause
> confusion. QSPI1_D[0] is in fact muxed on pad U1 (gpmc_a16),
> and QSPI1_D[1] - on pad P3 (gpmc_a17). Fixing comments.
> 
> Signed-off-by: Lubomir Popov <l-popov@ti.com>
> Reviewed-by: Tom Rini <trini@ti.com>

Applied to u-boot-ti/master, thanks!
diff mbox

Patch

diff --git a/board/ti/dra7xx/mux_data.h b/board/ti/dra7xx/mux_data.h
index 7276014..4824077 100644
--- a/board/ti/dra7xx/mux_data.h
+++ b/board/ti/dra7xx/mux_data.h
@@ -130,8 +130,8 @@  const struct pad_conf_entry core_padconf_array_essential[] = {
 	{GPMC_A13, (IEN | PDIS | M1)},  /* QSPI1_RTCLK */
 	{GPMC_A14, (IEN | PDIS | M1)},  /* QSPI1_D[3] */
 	{GPMC_A15, (IEN | PDIS | M1)},  /* QSPI1_D[2] */
-	{GPMC_A16, (IEN | PDIS | M1)},  /* QSPI1_D[1] */
-	{GPMC_A17, (IEN | PDIS | M1)},  /* QSPI1_D[0] */
+	{GPMC_A16, (IEN | PDIS | M1)},  /* QSPI1_D[0] */
+	{GPMC_A17, (IEN | PDIS | M1)},  /* QSPI1_D[1] */
 	{GPMC_A18, (M1)},  /* QSPI1_SCLK */
 	{GPMC_A3, (IEN | PDIS | M1)},   /* QSPI1_CS2 */
 	{GPMC_A4, (IEN | PDIS | M1)},   /* QSPI1_CS3 */