Patchwork pata_octeon_cf.c: use resource_size()

login
register
mail settings
Submitter hartleys
Date Dec. 11, 2009, 1:03 a.m.
Message ID <BD79186B4FD85F4B8E60E381CAEE190901FB0FB6@mi8nycmail19.Mi8.com>
Download mbox | patch
Permalink /patch/40893/
State Not Applicable
Delegated to: David Miller
Headers show

Comments

hartleys - Dec. 11, 2009, 1:03 a.m.
It appears the size for cs1 is calculated using the wrong resource.
Use the function resource_size to get the correct value.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>

---

--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Jeff Garzik - Dec. 17, 2009, 6:03 a.m.
On 12/10/2009 08:03 PM, H Hartley Sweeten wrote:
> It appears the size for cs1 is calculated using the wrong resource.
> Use the function resource_size to get the correct value.
>
> Signed-off-by: H Hartley Sweeten<hsweeten@visionengravers.com>

applied


--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/drivers/ata/pata_octeon_cf.c b/drivers/ata/pata_octeon_cf.c
index d6f6956..37ef416 100644
--- a/drivers/ata/pata_octeon_cf.c
+++ b/drivers/ata/pata_octeon_cf.c
@@ -853,7 +853,7 @@  static int __devinit octeon_cf_probe(struct platform_device *pdev)
 			return -EINVAL;
 
 		cs1 = devm_ioremap_nocache(&pdev->dev, res_cs1->start,
-					   res_cs0->end - res_cs1->start + 1);
+					   resource_size(res_cs1));
 
 		if (!cs1)
 			return -ENOMEM;