From patchwork Thu Dec 10 18:09:52 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: [02/17] ne2000: switch to symbolic names for pci registers Date: Thu, 10 Dec 2009 08:09:52 -0000 From: "Michael S. Tsirkin" X-Patchwork-Id: 40851 Message-Id: <20091210180952.GC25707@redhat.com> To: Anthony Liguori , qemu-devel@nongnu.org Cc: No functional changes. I verified that the generated binary does not change. Signed-off-by: Michael S. Tsirkin --- hw/ne2000.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/hw/ne2000.c b/hw/ne2000.c index d1416cf..78fe14f 100644 --- a/hw/ne2000.c +++ b/hw/ne2000.c @@ -724,7 +724,8 @@ static int pci_ne2000_init(PCIDevice *pci_dev) pci_config_set_device_id(pci_conf, PCI_DEVICE_ID_REALTEK_8029); pci_config_set_class(pci_conf, PCI_CLASS_NETWORK_ETHERNET); pci_conf[PCI_HEADER_TYPE] = PCI_HEADER_TYPE_NORMAL; // header_type - pci_conf[0x3d] = 1; // interrupt pin 0 + /* TODO: RST# value should be 0. PCI spec 6.2.4 */ + pci_conf[PCI_INTERRUPT_PIN] = 1; // interrupt pin 0 pci_register_bar(&d->dev, 0, 0x100, PCI_BASE_ADDRESS_SPACE_IO, ne2000_map);