diff mbox

[v2,5/5] package: linux-fusion: use install instead of cp

Message ID 1415332238-31677-6-git-send-email-guido@vanguardiasur.com.ar
State Superseded
Headers show

Commit Message

Guido Martínez Nov. 7, 2014, 3:50 a.m. UTC
in order to not depend on the previous permissions of the file

Signed-off-by: Guido Martínez <guido@vanguardiasur.com.ar>
---
 package/linux-fusion/linux-fusion.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Danomi Manchego Nov. 7, 2014, 12:44 p.m. UTC | #1
Guido

On Thu, Nov 6, 2014 at 10:50 PM, Guido Martínez
<guido@vanguardiasur.com.ar> wrote:
> in order to not depend on the previous permissions of the file
>
> Signed-off-by: Guido Martínez <guido@vanguardiasur.com.ar>
> ---
>  package/linux-fusion/linux-fusion.mk | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/package/linux-fusion/linux-fusion.mk b/package/linux-fusion/linux-fusion.mk
> index c5e7976..81ecd8a 100644
> --- a/package/linux-fusion/linux-fusion.mk
> +++ b/package/linux-fusion/linux-fusion.mk
> @@ -37,7 +37,7 @@ define LINUX_FUSION_INSTALL_TARGET_CMDS
>                 INSTALL_MOD_PATH=$(TARGET_DIR) \
>                 -C $(@D) install
>         mkdir -p $(LINUX_FUSION_ETC_DIR)
> -       cp -dpf package/linux-fusion/40-fusion.rules $(LINUX_FUSION_ETC_DIR)
> +       install -m 644 package/linux-fusion/40-fusion.rules $(LINUX_FUSION_ETC_DIR)


How about also dropping the mkdir and doing:

       install -D -m 644 package/linux-fusion/40-fusion.rules
$(LINUX_FUSION_ETC_DIR)/40-fusion.rules

Danomi -


>  endef
>
>  $(eval $(generic-package))
> --
> 2.1.1
>
> _______________________________________________
> buildroot mailing list
> buildroot@busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
Guido Martínez Nov. 7, 2014, 1:16 p.m. UTC | #2
Hi Danomi

On Fri, Nov 07, 2014 at 07:44:50AM -0500, Danomi Manchego wrote:
> Guido
> 
> On Thu, Nov 6, 2014 at 10:50 PM, Guido Martínez
> <guido@vanguardiasur.com.ar> wrote:
> > in order to not depend on the previous permissions of the file
> >
> > Signed-off-by: Guido Martínez <guido@vanguardiasur.com.ar>
> > ---
> >  package/linux-fusion/linux-fusion.mk | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/package/linux-fusion/linux-fusion.mk b/package/linux-fusion/linux-fusion.mk
> > index c5e7976..81ecd8a 100644
> > --- a/package/linux-fusion/linux-fusion.mk
> > +++ b/package/linux-fusion/linux-fusion.mk
> > @@ -37,7 +37,7 @@ define LINUX_FUSION_INSTALL_TARGET_CMDS
> >                 INSTALL_MOD_PATH=$(TARGET_DIR) \
> >                 -C $(@D) install
> >         mkdir -p $(LINUX_FUSION_ETC_DIR)
> > -       cp -dpf package/linux-fusion/40-fusion.rules $(LINUX_FUSION_ETC_DIR)
> > +       install -m 644 package/linux-fusion/40-fusion.rules $(LINUX_FUSION_ETC_DIR)
> 
> 
> How about also dropping the mkdir and doing:
> 
>        install -D -m 644 package/linux-fusion/40-fusion.rules
> $(LINUX_FUSION_ETC_DIR)/40-fusion.rules
Ah yes, that's better. Will do for v3.

Thanks!

> 
> Danomi -
> 
> 
> >  endef
> >
> >  $(eval $(generic-package))
> > --
> > 2.1.1
> >
> > _______________________________________________
> > buildroot mailing list
> > buildroot@busybox.net
> > http://lists.busybox.net/mailman/listinfo/buildroot
diff mbox

Patch

diff --git a/package/linux-fusion/linux-fusion.mk b/package/linux-fusion/linux-fusion.mk
index c5e7976..81ecd8a 100644
--- a/package/linux-fusion/linux-fusion.mk
+++ b/package/linux-fusion/linux-fusion.mk
@@ -37,7 +37,7 @@  define LINUX_FUSION_INSTALL_TARGET_CMDS
 		INSTALL_MOD_PATH=$(TARGET_DIR) \
 		-C $(@D) install
 	mkdir -p $(LINUX_FUSION_ETC_DIR)
-	cp -dpf package/linux-fusion/40-fusion.rules $(LINUX_FUSION_ETC_DIR)
+	install -m 644 package/linux-fusion/40-fusion.rules $(LINUX_FUSION_ETC_DIR)
 endef
 
 $(eval $(generic-package))