Message ID | 1415307221.21526.0.camel@perches.com |
---|---|
State | Accepted, archived |
Delegated to: | David Miller |
Headers | show |
From: Joe Perches <joe@perches.com> Date: Thu, 06 Nov 2014 12:53:41 -0800 > Remove the dependency on the "warning" sysctl (net_msg_warn) > which is only used by the LIMIT_NETDEBUG macro. > > Convert the LIMIT_NETDEBUG use in DCCP_WARN to the more > common net_warn_ratelimited mechanism. > > This still ratelimits based on the net_ratelimit() > function, but removes the check for the sysctl. > > Signed-off-by: Joe Perches <joe@perches.com> Applied, thanks Joe. > What about the LIMIT_NETDEBUG stuff now? > > Maybe all of them might as well be net_dbg_ratelimited > even if it changes some of the logging levels. I think a straight conversion to net_dbg_ratelimited would be fine. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/net/dccp/dccp.h b/net/dccp/dccp.h index c678166..e4c144f 100644 --- a/net/dccp/dccp.h +++ b/net/dccp/dccp.h @@ -22,8 +22,8 @@ /* * DCCP - specific warning and debugging macros. */ -#define DCCP_WARN(fmt, a...) LIMIT_NETDEBUG(KERN_WARNING "%s: " fmt, \ - __func__, ##a) +#define DCCP_WARN(fmt, ...) \ + net_warn_ratelimited("%s: " fmt, __func__, ##__VA_ARGS__) #define DCCP_CRIT(fmt, a...) printk(KERN_CRIT fmt " at %s:%d/%s()\n", ##a, \ __FILE__, __LINE__, __func__) #define DCCP_BUG(a...) do { DCCP_CRIT("BUG: " a); dump_stack(); } while(0)