| Message ID | 1415281013-1077-3-git-send-email-gustavo@zacarias.com.ar |
|---|---|
| State | Superseded |
| Headers | show |
Dear Gustavo Zacarias, On Thu, 6 Nov 2014 10:36:48 -0300, Gustavo Zacarias wrote: > It's required by Debian ifupdown. > +13 KB for ARM. Does Debian ifupdown fails to build? If it does, then we'll have zillions of build failures with all the prebuilt uClibc toolchains that don't have wordexp enabled :/ Thomas
On 11/06/2014 02:22 PM, Thomas Petazzoni wrote: > Does Debian ifupdown fails to build? If it does, then we'll have > zillions of build failures with all the prebuilt uClibc toolchains that > don't have wordexp enabled :/ Yes, that's true. The series is RFC, i can add an exception for external toolchains, or alternatively just disable this for uClibc in general - after all enabling all the big versions is bloaty enough. Regards.
Dear Gustavo Zacarias, On Thu, 06 Nov 2014 14:25:43 -0300, Gustavo Zacarias wrote: > Yes, that's true. > The series is RFC, i can add an exception for external toolchains, or > alternatively just disable this for uClibc in general - after all > enabling all the big versions is bloaty enough. I just had a look at ifupdown source code, and wordexp() is pretty central in the code, not sure we can easily replace it with something else without significantly patching the stuff. I don't really have a good answer here. Maybe as you suggest disabling ifupdown entirely for uClibc toolchains? I've also checked Crosstool-NG, and all its default uClibc configuration files have wordexp disabled, so both Buildroot pre-built toolchains predating the wordexp addition and all Crosstool-NG uClibc toolchain would be affected by the problem. Thomas
On 11/06/2014 02:45 PM, Thomas Petazzoni wrote: > I just had a look at ifupdown source code, and wordexp() is pretty > central in the code, not sure we can easily replace it with something > else without significantly patching the stuff. > > I don't really have a good answer here. Maybe as you suggest disabling > ifupdown entirely for uClibc toolchains? I've also checked > Crosstool-NG, and all its default uClibc configuration files have > wordexp disabled, so both Buildroot pre-built toolchains predating the > wordexp addition and all Crosstool-NG uClibc toolchain would be > affected by the problem. Yes it's valid since it's bloat-land anyway, i'll wait for more feedback but i'm inclined to just do that for v2. And most of these standalone tools aren't happy with nommu anyway which would be the only incentive to stick with uClibc. Regards.
diff --git a/package/uclibc/uClibc-0.9.31.config b/package/uclibc/uClibc-0.9.31.config index 76772e8..12db6b2 100644 --- a/package/uclibc/uClibc-0.9.31.config +++ b/package/uclibc/uClibc-0.9.31.config @@ -190,7 +190,7 @@ UCLIBC_HAS_REGEX=y # UCLIBC_HAS_REGEX_OLD is not set UCLIBC_HAS_FNMATCH=y # UCLIBC_HAS_FNMATCH_OLD is not set -# UCLIBC_HAS_WORDEXP is not set +UCLIBC_HAS_WORDEXP=y UCLIBC_HAS_NFTW=y UCLIBC_HAS_FTW=y UCLIBC_HAS_GLOB=y diff --git a/package/uclibc/uClibc-0.9.33.config b/package/uclibc/uClibc-0.9.33.config index 1b07d4a..9db13d1 100644 --- a/package/uclibc/uClibc-0.9.33.config +++ b/package/uclibc/uClibc-0.9.33.config @@ -226,7 +226,7 @@ UCLIBC_HAS_REGEX=y # UCLIBC_HAS_REGEX_OLD is not set UCLIBC_HAS_FNMATCH=y # UCLIBC_HAS_FNMATCH_OLD is not set -# UCLIBC_HAS_WORDEXP is not set +UCLIBC_HAS_WORDEXP=y UCLIBC_HAS_NFTW=y UCLIBC_HAS_FTW=y # UCLIBC_HAS_FTS is not set diff --git a/package/uclibc/uClibc-snapshot.config b/package/uclibc/uClibc-snapshot.config index ffc1535..e38bdc3 100644 --- a/package/uclibc/uClibc-snapshot.config +++ b/package/uclibc/uClibc-snapshot.config @@ -231,7 +231,7 @@ UCLIBC_HAS_REGEX=y # UCLIBC_HAS_REGEX_OLD is not set UCLIBC_HAS_FNMATCH=y # UCLIBC_HAS_FNMATCH_OLD is not set -# UCLIBC_HAS_WORDEXP is not set +UCLIBC_HAS_WORDEXP=y UCLIBC_HAS_NFTW=y UCLIBC_HAS_FTW=y # UCLIBC_HAS_FTS is not set
It's required by Debian ifupdown. +13 KB for ARM. Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar> --- package/uclibc/uClibc-0.9.31.config | 2 +- package/uclibc/uClibc-0.9.33.config | 2 +- package/uclibc/uClibc-snapshot.config | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-)